Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Patch attached allows easier translation and it's also easier to understand for everyone as a key could be anything.
Comments
Comment #1
hass CreditAttribution: hass commentedComment #2
hass CreditAttribution: hass commentedD8 patch
Comment #3
BarisW CreditAttribution: BarisW commentedPatch looks good, although an invalid theme hook call still results in this error:
But that should be another issue. This patch is fine ;)
Comment #4
catchThanks, theme hook is better here. Committed/pushed to 8.x.
Comment #5
hass CreditAttribution: hass commentedD7 Patch is in #1.
Comment #6
hass CreditAttribution: hass commented#1: core+Change+wording+theme+key+to+theme+hook+for+translation+reasons-D7.patch queued for re-testing.
Comment #7
hass CreditAttribution: hass commentedWhat is holding this patch back?
Comment #8
dcam CreditAttribution: dcam commentedThe patch in #1 contains the same changes that were applied to D8. The attached image shows the error log messages before and after the patch was applied.
The patch looks good to me. Marking as RTBC.
Comment #9
David_Rothstein CreditAttribution: David_Rothstein commentedI'm not sure why we're getting rid of the quotes, but this is an obscure enough log message that it doesn't matter much. Also, it's a string change, so I probably should have committed this earlier in the release cycle... but again, it's an obscure string - and also one that is completely wrong and confusing in its current form, so I think untranslated but correct might be better than translated but incorrect in this case :)
Therefore, committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/815faef