Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I have performed few code style fixes mainly with dyoxygen docs in apps.manifest.inc but also got rid of PHP notices for certain cases when you have minimalistic manifest definitions (e.g. without screenshots).
Please review the patch.
Comment | File | Size | Author |
---|---|---|---|
#5 | apps-code-style-fixes-1728432_0.patch | 9.12 KB | neochief |
#3 | apps-code-style-fixes-1728432.patch | 9.33 KB | neochief |
#1 | apps-code-style-fixes-1728432.patch | 9.33 KB | neochief |
Comments
Comment #1
neochief CreditAttribution: neochief commentedComment #2
febbraro CreditAttribution: febbraro commentedThis looks good and I tried to commit, but the patch does not cleanly apply for me. Can you reroll it?
Comment #3
neochief CreditAttribution: neochief commentedTry this one.
Comment #4
febbraro CreditAttribution: febbraro commentedHey @neocheif, I'm sorry, it still does not apply. By looking at the start of your patch (seeing the define labeled INSTALLABLE) it seems like this is based on a pretty old version of the source code. Can you try to merge in the latest changes in the dev branch see how that goes?
Here are my errors. http://cl.ly/image/3F3g1f0w3o3S
Comment #5
neochief CreditAttribution: neochief commentedHere's the re-roll. Tested patch with your commands, it works, except 5 whitespace warings, which is not critical. In case I've chosen wrong branch, I'm creating patches against 7.x-1.x.
Comment #6
hefox CreditAttribution: hefox commentedAnother code style issue was commited so please reroll with whatever left to be changed.
I believe param structure is
@param [type]
description
e.g. two lines