Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
$explanation = t('Field type(s) in use - see !link', array('!link' => l(t('Field list'), 'admin/reports/fields')));
Should be changed according to http://drupal.org/node/322774.
Comment | File | Size | Author |
---|---|---|---|
#2 | 1587822-8.patch | 699 bytes | bfroehle |
#1 | 1587822.patch | 983 bytes | drumm |
Comments
Comment #1
drummPatch attached.
Comment #2
bfroehle CreditAttribution: bfroehle commentedAnd for D8.
Comment #3
hass CreditAttribution: hass commentedLooks code wise correct.
Comment #4
Dries CreditAttribution: Dries commentedCommitted to 8.x. We should probably backport this to 7.x.
Comment #5
bfroehle CreditAttribution: bfroehle commentedThe patch in #1 is for 7.x.
Comment #6
tim.plunkettTagging.
Comment #7
David_Rothstein CreditAttribution: David_Rothstein commentedDo we know that this particular string is causing issues for translators due to the way it's currently set up?
I know in general this is bad practice, but not sure it's worth breaking D7 translations for unless we know of an actual problem (i.e. lack of context) that this specific string is causing the translations currently.
Because if we do change it, we make a whole bunch of translators go back and redo their work, right?
Comment #8
hass CreditAttribution: hass commentedTranslation is no problem... We can change this string... Core has no 100% complete translations... L10n_update will refresh all strings... We fixed hundreds of strings in DE translation in past 2 months, too. Since we are no longer using .PO files I see no longer a reason to hold string changes back.
Comment #9
David_Rothstein CreditAttribution: David_Rothstein commentedIt still causes English strings to appear on sites that previously had it translated, until someone does the work to re-translate it for whichever language the site is using.
Per http://drupal.org/node/1527558 I suppose we can consider this though (especially since it's an admin-only string)... but let's wait until right after the next Drupal 7 release to commit it, as described in the guidelines there. Leaving at RTBC for now.
Comment #10
hass CreditAttribution: hass commentedDo you know how many strings are not translated? :-) there is no 100% translation and if we talk about quality... OMG
Comment #11
webchickPer David, holding this until after 7.15. If you want to make sure this happens faster, please help with release blockers! :)
Comment #12
David_Rothstein CreditAttribution: David_Rothstein commentedAh, I actually messed up here a bit. I wanted to wait until after the 7.15 release to commit it because (at the time I wrote the above) it seemed like 7.15 might potentially be imminent. But then once the release got postponed by a month or so, I could have come back here and committed it then.
Sorry about that, but at this point, let's just wait. This string is not causing any active harm to anyone in its current form. I'll plan to get it committed right after the next Drupal 7 release comes out, though.
Comment #13
drummUntagging for D.o -> D7, this was worked around.
Comment #14
webchickOk it's now after 7.15, so committed and pushed this to 7.x. Thanks!
Comment #16
David_Rothstein CreditAttribution: David_Rothstein commentedString change, so adding this to the release notes and CHANGELOG.txt.