Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Title says it all, patch coming up.
Use this core issue to run the tests: #1735118: Convert Field API to CMI
Comment | File | Size | Author |
---|---|---|---|
#5 | 1738284-5.patch | 50.72 KB | swentel |
#3 | 1738284-3.patch | 43.21 KB | swentel |
#2 | 1738284-2.patch | 43.17 KB | swentel |
#1 | 1738284-1.patch | 34.49 KB | swentel |
Comments
Comment #1
swentel CreditAttribution: swentel commentedComment #2
swentel CreditAttribution: swentel commentedField tests turn green, going to run this patch also over at #1735118: Convert Field API to CMI to see what the testbot says for all the rests.
Comment #3
swentel CreditAttribution: swentel commentedForgot something small thing, new patch.
Comment #4
alexpottI think that the save come before the delete just in case the delete fails.
As above. Perhaps config's storageInterface should support renames?
We could use setData here instead of adding the unnecessary level 'conf'
Above is a dumped field contains duplicated data storage array vs storage__NAME_ - swentel says this is happening due to an array stored as a serialised string in the database (the data column).
Comment #5
swentel CreditAttribution: swentel commentedThis patch implements the hook_config_import_create/update/delete functions.
It fixes the file_managed table as well
Nothing done yet from the comments in #4
Cheated for the node type test at this point.
Also we need to cast the allowed values to strings so they preserve order
Comment #6
alexpottI've created a branch 1735118-field-cmi-swentel in http://drupal.org/sandbox/yched/1736366 - see http://drupalcode.org/sandbox/yched/1736366.git/shortlog/refs/heads/1735...
This issue has been deprecated in favour of #1735118: Convert Field API to CMI