Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
During the display of the media browser, we're using the square_thumbnail image style, which we've specified to scale to 180x180. However, the css in the browser further shrinks it to a 100px width. Which do we want?
The 100px?
or the 180px?
I'll attach a patch for either, once we have a consensus: we either need to change the image style to 100px, or change the css to 180px.
Comment | File | Size | Author |
---|---|---|---|
#7 | media_zoom_slider-1024844-7.patch | 3.01 KB | idflood |
#7 | zoom-icons.png | 224 bytes | idflood |
#6 | media-zoom-mockup1.jpg | 80.97 KB | idflood |
#5 | media_zoom_slider-1024844-5.patch | 2.23 KB | idflood |
Comments
Comment #1
aaron CreditAttribution: aaron commentedAlternatively, we could keep both, and add a style switcher in the browser, which could be cool, and is similar to a demo by mverbaar during d7ux. Now that I think about it, I'm leaning in that direction...
Comment #2
aaron CreditAttribution: aaron commentedimages here:
100px
180px
Comment #3
Jackinloadup CreditAttribution: Jackinloadup commentedIt would be great if we could use a jQuery UI slider to adjust the size from say 40 or 60 to the full 180. Thoughts?
Comment #4
JacobSingh CreditAttribution: JacobSingh commentedComment #5
idflood CreditAttribution: idflood commentedHere is a first patch that adds a slider to control the zoom level for the thumbs (from 50px to 180px by increment of 10px).
I think there will be something to do to reapply the style to dynamically loaded thumb but I may be wrong. And this will also obviously need some specific styling.
Comment #6
idflood CreditAttribution: idflood commentedmaybe it can looks something like that. what do you think?
Comment #7
idflood CreditAttribution: idflood commentedhere is a patch that make look the slider like in the proposed mockup above. The image needs to be added in the "images" folder.
Comment #8
Dave ReidAssigning for review.
Comment #9
jerryitt CreditAttribution: jerryitt commentedApplied and tested #7 "media_zoom_slider-1024844-7.patch" against the current 7.x-1.x...
Works as described in #6.
Comment #10
dddave CreditAttribution: dddave commentedIs this still happening/relevant?
Comment #11
ParisLiakos CreditAttribution: ParisLiakos commentedwell it doesnt not apply at all
Comment #12
ezra-g CreditAttribution: ezra-g commentedThis was fixed as part of #1881152: Browser display cleanup.