Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In privatemsg_privatemsg_name_lookup the str_replace strips out spaces, because of wrapping [user] in the t-function.
Removing the t(), makes it work.
Patch against current 1.x-dev follows.
Thanks,
Walter
Comment | File | Size | Author |
---|---|---|---|
#1 | user-spaces-1751252-2.patch | 627 bytes | valderama |
Comments
Comment #1
valderama CreditAttribution: valderama commentedHere is a patch..
Comment #2
valderama CreditAttribution: valderama commentedsetting to needs review,
thanks,
walter
Comment #3
Sutharsan CreditAttribution: Sutharsan commentedI think the patch is good, but IMHO for the wrong reason. It does not strip spaces, unless someone translated '[user]' with at space.
What is t('[user]') doing here anyway? The string should not be translated at all, it is a token. It is not even the value of the token.
Comment #4
ptmkenny CreditAttribution: ptmkenny commentedPatch should not be accepted "as is" because of the issue with t() noted in #3.
Comment #5
Sutharsan CreditAttribution: Sutharsan commented@ptmkenny, but what problem are we solving here? In my view the patch is good, because it removes an unwanted t().
Comment #6
ptmkenny CreditAttribution: ptmkenny commentedAh, sorry, I misread your comment. Setting it back...
Comment #7
BerdirCommitted and pushed to all relevent patches, thanks for testing.