This is a spin-off from #1510532: [META] Implement the new create content page design which aims to implement only the updated form styles as per the visuals in that ticket. Unfortunately, to apply this you will need to apply these other patches in order (sorry, but I can see no other way to do this.. it's better than the monolithic patch from 1510532!). This patch does not implement the styles needed to do the right column, since the actual implementation of that is yet undecided. See referenced ticket for more info.

#1747868: Modern CSS reset in Seven
#1238484: Ability to mark the form buttons to be of a specific type (so that they can be styled differently)
#1751606: Move published status checkbox next to "Save"

In order to help test this, I also have a little module that generates lots of form elements (attached). With this module installed, you can visit /mrfelton to see a while bunch of form elements, or /mrfelton/disabled to see the same elements in their disabled state. Screenshots attached.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mrfelton’s picture

The patch...

Status: Needs review » Needs work

The last submitted patch, 1751754-1-seven-blueprint-form-style.patch, failed testing.

mrfelton’s picture

Status: Needs work » Needs review
FileSize
26.71 KB

Updated patch adds the triangle image which I forgot to include in the commit. It also removes some styling that related to the 2 column layout which has not yet been implemented properly.

Status: Needs review » Needs work

The last submitted patch, 1751754-2-seven-blueprint-form-style.patch, failed testing.

mrfelton’s picture

Status: Needs work » Needs review

Setting back to review. Testbot can not follow patch dependencies.

kika’s picture

Unfortunately, to apply this you will need to apply these other patches in order

How hard is to make this patch not to be dependent on the other spin-off patches?

mrfelton’s picture

It would be easy except for 2 things.

1. The other patches provide adjustments to the css themselves, to the same parts of the css files that this patch alters.

2. This patch introduces new form styles for elements and classes introduced by the other patches.

mrfelton’s picture

I think that #1238484: Ability to mark the form buttons to be of a specific type (so that they can be styled differently) is pretty much a sealed deal. I expect (hope!) that it, or something almost identical to it to be committed very soon. I have updated this patch so that it applies against latest core, tested in more browsers, and fixed several issues that I found.

Sorry - another patch dependency here... you really need #723392: Tame seven's reset.css applied before applying this, since the existing reset in Seven is crazy stupid, and there is no point in trying to work around that here given that there is a general consensus to replace the reset with a cleaner one, and we are well on the way to doing that with the aforementioned patch. Lets hope that can get committed soon too!

Here is a screenshot from Chrome: http://www.diigo.com/item/image/3aqdh/x7am

I'd say we are about 80% there with this now. There are some minor issues, like the image button, and the file widgets. And, it needs a lot more cross browser testing.

Status: Needs review » Needs work

The last submitted patch, 1751754-8-seven-modern-form-style.patch, failed testing.

klonos’s picture

Status: Needs work » Needs review
klonos’s picture

Status: Needs review » Needs work

The last submitted patch, 1751754-8-seven-modern-form-style.patch, failed testing.

sannejn’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: +Needs accessibility review, +d8ux

The last submitted patch, 1751754-8-seven-modern-form-style.patch, failed testing.

sannejn’s picture

FileSize
4.7 KB
4.54 KB

Updated the patch, should be working now. I tried to save as much as possible from the original patch, and updated some stuff in line with the styleguide. This is just a start, lot's of work to be done.

sannejn’s picture

Status: Needs work » Needs review
ry5n’s picture

I’m really glad this is being worked on, but I’ve been getting worried that since it’s based on a single comp done for one screen (the content creation screen) it’s not comprehensive enough. Right now in core we have a bunch of new features and UX improvements, and with them has come a lot of inconsistency in our UI styling. So for a while, I’ve been working on evolving and consolidating all of the look-and-feel for the Seven theme, bringing it up-to-speed with D8’s new features and helping to make everything both consistent and ensure that it reflects the Drupal brand. I worked from a number of sources, including the the design for the content creation screen, D7’s existing Seven styles, and the work being done for Spark.

The result is a proposed style guide for the Seven theme that myself, Bojhan and yoroy posted this weekend on g.d.o. Although it looks fairly polished, it’s not my intention to “push it through”. The design and rationale needs road testing and more iteration, and I’m happy to discuss any changes (big or small). Since you’ve been working on this issue, I especially would like your input:

http://groups.drupal.org/node/283223

sannejn’s picture

I'll have a look at it as soon as possible!

yoroy’s picture

With the style guide in solid shape at http://groups.drupal.org/node/283223, what is the best way to tackle its implementation for Seven? Maybe discuss that in #1088792: [meta] Seven theme battle plan for D8, but wanted to let you all in here know as well.

mgifford’s picture

#15: 1751754-15.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Needs accessibility review, +d8ux

The last submitted patch, 1751754-15.patch, failed testing.

mgifford’s picture

FileSize
4.67 KB

Reroll

mgifford’s picture

Status: Needs work » Needs review

forgot the bot...

LewisNyman’s picture

#22: 1751754-22.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Needs accessibility review, +d8ux

The last submitted patch, 1751754-22.patch, failed testing.

LewisNyman’s picture

Status: Needs work » Closed (duplicate)

Tentatively closing this issue as a duplicate of the styleguide implementation issues. #1986434: New visual style for Seven