Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
When you remove the WYSIWYG library for an active profile, the text declaring which WYSIWYG the profile uses is replaced by a smooth blank space. Some indicator of "Missing Plugin" would be helpful.
Comment | File | Size | Author |
---|---|---|---|
#10 | wysiwyg-missing-editor.771424.10.patch | 2.53 KB | TwoD |
#1 | wysiwyg-D6-771424.patch | 947 bytes | TwoD |
#1 | wysiwyg-D5-771424.patch | 990 bytes | TwoD |
Comments
Comment #1
TwoDAh, good point.
I changed it to read WARNING: %editor library is missing! where %editor is the title of the assigned editor.
This requires separate patches for D5/6/7 due to changes in FAPI, but they're almost the same.
Comment #2
sunThe "WARNING:" is normally done by applying the "warning" CSS class to a table row.
Overall, we should test-drive this patch a bit in HEAD, before attempting to backport it.
I was under the impression that the installation instructions fieldset should get automatically expanded in case a library is missing?
Powered by Dreditor.
Comment #3
TwoDYeah, it should, but I guess people don't notice that. This change would perhaps also make it a bit more obvious which text formats are affected?
Comment #4
joachim CreditAttribution: joachim commented> I was under the impression that the installation instructions fieldset should get automatically expanded in case a library is missing?
Didn't seem to do that for me:
Comment #5
Grayside CreditAttribution: Grayside commentedAn expanding fieldset is useful to help you get the library, but it's a poor warning mechanism when you are *sure* you already downloaded and got a library working for the site in the past.
Comment #6
TwoDNot sure I like the rendering logic, but I didn't find a cleaner solution.
The fieldset won't expand when an editor is not installed at all, as it doesn't check if a profile uses it and thus doesn't know it should be installed.
UPDATE: This also fixes
Comment #7
TwoDStupid status field, keeps doing the opposite of what I want...
Comment #8
helmo CreditAttribution: helmo commented@TwoD: Git is complaining about the line endings in your patch.
This is true when you had only one editor. When you have multiple installed the image from #4 is what you get.
The patch from #6 fixes this nicely. I re-rolled it just for the line endings.
Comment #9
TwoDChanged a few things to better indicate which library is missing and to not rely on translated string comparison in the theme function.
Is this too much?
Comment #10
TwoDArgh! Stupid Windows hiding the real file extension!
Wouldn't surprise me if git complains about file endings being wrong this time too, despite that I've never actually opened the file in Windows...
Comment #11
rocketeerbkw CreditAttribution: rocketeerbkw commented#10 still applies cleanly to 7.x-2.x HEAD and fixes the problems described
Comment #12
sunSlightly ;) shortened the warning message...
Thanks for reporting, reviewing, and testing! Committed to 7.x-2.x.
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.
Comment #14
TwoDBackported this to 6.x.