Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
'Coupons' checkout pane -> DISPLAY SETTINGS
The checkbox 'Include this pane on the Review checkout pane.' disabled.
But, the coupon are displayed in the checkout process.
Comment | File | Size | Author |
---|---|---|---|
#14 | commerce_coupon-unlock_checkout_pane-1654990-12.patch | 495 bytes | firfin |
#8 | coupon.in_.checkout.png | 253.93 KB | firfin |
#8 | none.selected.as_.pane_.view_.png | 55.25 KB | firfin |
#5 | coupon.settings.no_.none_.png | 32.58 KB | firfin |
Comments
Comment #1
pcambraI've just tried this and can't reproduce it.
I add a coupon to the order, and continue to the review page and the pane with coupons is not displayed if the setting is disabled
Also, please check the priority level of issues
Comment #2
firfin CreditAttribution: firfin commentedI suspect you might be talking about different pages. checkout vs. review.
On the store -> configuration -> checkout form -> coupons page:
When I deselect the checkbox 'Include this pane on the Review checkout pane' the coupon info/pane is still visible on the 'checkout' page (e.g. /checkout/[orderid] ). But no longer on the 'review order' page (checkout/[orderid]/review)
Maybe the text for the checkbox is a bit confusing? Might 'Include this pane on the Review order pane' be more clear.
I hope this clears up this discussion.
I assume what quiptime is trying to accomplish ( I know I am) is making the coupons pane on the checkout page disappear altogether. I am basing this on his other issues in the queue (none of which are critical IMHO ;) )
I tried to accomplish this by disabling the coupons pane.
Unfortunately I am rewarded with the following warning:
Is there a reason why the Coupons pane is set to locked?
Comment #3
firfin CreditAttribution: firfin commentedi got around the coupons/checkoutpage lock by defining hook_commerce_checkout_pane_info_alter() in a custom module.
However, I am still wondering if this adversely affects the operation of commerce_coupons. Any thoughts?
Comment #4
pcambraThat's the exact behavior I would expect and it is being included by commerce in all checkout panes. Review checkout pane is also configurable, it's the one called "Review".
If you want the coupon listing hidden in the checkout page, you just need to select 'none' in the option "Coupons Checkout Pane View", see screenshot.
https://skitch.com/pcambra/epgdp/coupons-checkout-pane-commerce-kickstart
Comment #5
firfin CreditAttribution: firfin commentedThanks for the screenshot Pedro! Suddenly it is clear that I am missing something.
I have not got a option (also see screenshot. Not yet clear why not.
Will dig into it.
Anyone have a clue?
Comment #6
pcambraComment #7
firfin CreditAttribution: firfin commentedProblem has disappeared in the 1.0-beta 6 version. Probably because of #1654996: Wrong 'Coupons' checkout pane configuration option
Strange I missed this issue when I first looked at this problem, anyways : All's well that ends well.
So good work (again! )
Comment #8
firfin CreditAttribution: firfin commentedSadly I was mistaken. coupons pane still shows up .
However there is hope, since the beta6 version the 'none' option turns up as an option.
Unfortunately it doesn't seem to do anything (or perhaps I misunderstand it's purpose.)
The coupons-pane wasn't turning up because I had a mycustommodule_commerce_checkout_pane_info_alter() lying around somewhere. This lets me disable the coupons pane (see comment 3).
If I don't have this hook redefined, the coupons pane still shows up. (see screenshot 'coupon in checkout') Or rather without the redefine i get the 'locked in code' message when i try to disable the coupons pane.
So I have a workaround in any case, but I'd rather this module works as expected, or that I have correct expectations of it :-)
The problem:
I have none selected as the 'coupons checkout pane view' (see screenshot ) The none options did not show up in beta5. It does now, but it doesn't do what I expect. The coupons pane is still visible on checkout.
Using all the newest modules (according to drush up )
Made a snapshot of the current state, so I can try whatever is needed.
Comment #9
pcambraI don't see anything wrong in your screenshots.
Comment #10
firfin CreditAttribution: firfin commentedMy findings so far, or a summary:
I just started over with a fresh (never installed coupons) shop.
On the checkout settings page ( admin/commerce/config/checkout/form ) I have the following settings:
- "Include this pane on the Review checkout pane." is NOT checked
- "Coupons Checkout Pane View " is set to 'None'
Save setting and then go to the checkout page ( /checkout/XX) and voila, the box to enter a coupon is STILL there. At no point have I entered a coupon code.
What don't I understand? Or is this not supposed to happen?
----- current workaround , I can supply a patch for this if you want.
Most panes can be dragged to disabled using the checkout settings. This is pretty standard behaviour for most panes. When I try this with the Coupons pane I get the 'coupons pane is locked' message. This is because of the
'locked' => TRUE
, setting incommerce_coupon_commerce_checkout_pane_info()
.Why should this pane be locked?
Why disallow users to change the position of, or disable, the coupons pane?
Anyways, implementing
hook_commerce_checkout_pane_info_alter()
and setting locked to FALSE in a custom module allows me to disable the coupons pane.Comment #11
firfin CreditAttribution: firfin commentedon http://drupal.org/files/coupon.in_.checkout.png in the bottom there is a textfield ('coupon code') to enter a coupon code.
I do not want it there (I use rules to 'add' coupon based on certain actions)
Maybe this is the basis for the misunderstanding in this issue?
Comment #12
pcambraI'm definitely not following you. If you don't want the coupon form in the checkout, you should
removemove the coupon's pane to the Disabled area in the checkout settings, the settings you're mentioning are for the listing of coupons applied to the order.Comment #13
pcambraIf you try to move the coupons pane to Disabled or other checkout page you would get this message:
This is due that the coupons pane is set as locked when it shouldn't. See #10 for more details.
We should unlock this.
Comment #14
firfin CreditAttribution: firfin commentedAt the moment it is not possible to move the coupon checkout pane on the commerce 'checkout settings' page. The pane is locked in code.
As agreed upon on IRC, the coupon checkout pane need not be locked. This patch 'unlocks' it.
Comment #15
firfin CreditAttribution: firfin commentedreset the title and priority
Comment #16
pcambraCommitted thanks!