Rule event 'after video encoding success' triggered incorrectly [#1698046]

Using zencoder option - I have implemented a rule to fire an email to a node author on the event 'after video encoding success' - which I assumed would fire when the video file is successfully returned from Zencoder (on postback).

However, the rule is firing on node save or on cron, depending on which option I use (i.e. on successfully submitting the file to Zencoder)..... not after encoding success.

This needs fixing so the event is only triggered on postback, otherwise, in my case, users are informed that the video has been processed prematurely.

Comments

Comment #1

Tsubo CreditAttribution: Tsubo commented 23 July 2012 at 19:19

Title:

Rule event 'after video encoding success' tiggered incorrectly

» Rule event 'after video encoding success' triggered incorrectly

fixed typo in title.

Comment #2

aasarava CreditAttribution: aasarava commented 24 August 2012 at 18:45

Same problem here.

It seems the "video_success" call is invoked in the process() function in includes/Conversion.inc. But when you use Zencoder, the process function queues up the job, so calling video_success here would be too early. Maybe it makes more sense to move the video_success and video_failed events to the TranscoderAbstractionFactories for ffmpeg and zencoder?

The other issue that would pop up with Zencoder is that multiple outputs result in multiple postbacks. Either we need to consolidate outputs into one job request, so that there's only one postback (if that's possible). Or else, we need to track how many outputs (presets) were requested and only fire the success event once the last one comes back and is successful.

Jorrit, what do you think?

Comment #3

Jorrit CreditAttribution: Jorrit commented 25 August 2012 at 10:15

I know this is a bug and what causes it, I just haven't had time to fix it. Ideally, the rules functionality would be put in a separate submodule and greatly improved.

For the multiple videos per job there already is a ticket #1547122: Support multiple outputs per job for zencoder. Until that is implemented, I think I will fire an event for the first successful postback. It is not ideal, but the best I can do now.

Comment #4

Jorrit CreditAttribution: Jorrit commented 1 September 2012 at 20:59

Component:	Video Core	» Rules
Assigned:	Unassigned	» Jorrit

Comment #5

aasarava CreditAttribution: aasarava commented 2 September 2012 at 03:51

If the patch for multiple outputs (#1547122) looks good, then it should be fairly easy to check in processPostback if a Zencoder job is finished, like so:

    if ($notification->job->state == 'finished') {
      if (module_exists('rules') && $video->entity_type == 'node') {
        rules_invoke_event('video_success', node_load($video->entity_id));
      }
    }

This should only get triggered once, after all outputs have been converted by Zencoder.