hook_field_formatter_prepare_view never called for entity fields attached to the current node on a node page

Triggering the testbot.

Can you reproduce with entityreference module? References is on its way out, and I think that it might just be a bug on its end.

per tim.plunkett's comments, I'm going to 'won't fix' this.

I believe I am experience this issue with Entity Reference. I'll post again when I know more, but right now I am certain that entityreference_field_formatter_prepare_view() isn't being called when showing a block as a Display Suite field. The Views block has a NID argument (successfully populating), and the single entity reference field is shown as "Rendered Entity."
If I render the block as a normal block, everything works find. If I put the block into Display Suite, it gives me this error:

Fatal error: __clone method called on non-object in [module_path_here]/entityreference.module on line 1012.

Within entityreference.module, around line 1012.
WORKS: $entity = clone entity_load_single($entity_type, $item['target_id']);
BROKEN: $entity = clone $item['entity'];

So, after realizing the entities weren't loaded, I checked if entityreference_field_formatter_prepare_view() is executing, and it's not. That's where the entities were being loaded into $items.

Sorry this isn't a very put-together reply... but I wanted to get something out there to confirm I do believe there's an issue.

I just added the "unset($entity->_field_view_prepared);" line to modules/contrib/views/modules/field/views_handler_field_field.inc and found that the issue is resolved (without modification to entityreference or display suite).

Do you need more details? I know my last writeup was awfully sloppy.

I am experiencing this same issue with a similar setup as the original description. When I try to use a view from within display suite as a dynamic field the same error is thrown. There are also errors about a taxonomy reference I have as one of the fields in the content type.

Update: I am experiencing this issue with the latest dev build of entityreference

Update: adding unset($entity->_field_view_prepared); into views_handler_field_field.inc works fine, but I wonder if there is a better solution to this issue. Correct me if I am wrong, but wouldn't this cause some extra overhead to prepare fields that may have already been prepared? I am curious if this is going to cause a performance issue.

Could be related: #1281114: Database records not deleted for Term Reference Fields after Term is Deleted

Having similar error, but patch didn't help much.
Also tested taxonomy_orphanage module and it didn't detect any orphaned taxonomy references.
Backtrace: http://drupal.org/node/1778572#comment-7256200

Could be related to Search API:
#1402270: ResponseText: EntityMalformedException: Missing bundle property on entity of type profile2

I'm facing the same issue.

I'm facing the same issue and patch #1 has fixed it for me also.

Here's a way to test it out.

Have a taxonomy page that is using Taxonomy display.

On that taxonomy term add a Term reference field and reference to another term.

Then create a view for the term that would output the term reference field.

You'll run into the issue.

I can confirm the bug with Entity reference, the hook_field_formatter_prepare_view() never gets called, as a consequence the access flag added by this function is not added, and the hook_field_formatter_view() doesn't return anything because of this.
The patch makes it work.

i had that patch too when using https://www.drupal.org/project/embed_views to embed a view into a node.

the view itself worked perfectly, just when i mebedded it i got the error

EntityMalformedException: .. taxonomy_term. in entity_extract_ids() (Zeile 7734 von /mnt/www/WORKSPACE_DRUPAL/EIGENE_PROJEKTE/PRODUCT_DISTRI3/includes/common.inc).

#2268293: EntityMalformedException

As jsacksick said, this patch resolves a critical issue with entityreference module. The _field_view_prepared flag attached on passed entity prevents views to invoke entityreference own preparation callbacks and since the items to be rendered are not prepared, entityreference unsets them hence nothing is displayed.

This patch solves this issue for me!

We've recently switched our testing from the old qa.drupal.org to DrupalCI. Because of a bug in the new system, #2623840: Views (D7) patches not being tested, older patches must be re-uploaded. On re-uploading the patch, please set the status to "Needs Review" so that the test bot will add it to its queue.

If all tests pass, change the Status back to "Reviewed & tested by the community". We'll most likely commit the patch immediately without having to go through another round of peer review.

We apologize for the trouble, and appreciate your patience.

re-uploading patch for testing from #1 that was previously RTBC

From #7:

Update: adding unset($entity->_field_view_prepared); into views_handler_field_field.inc works fine, but I wonder if there is a better solution to this issue. Correct me if I am wrong, but wouldn't this cause some extra overhead to prepare fields that may have already been prepared? I am curious if this is going to cause a performance issue.

Let's have someone look into this first. Or is it still an issue?

I recently updated views to 7.x-3.14 and can confirm this patch is still required.

@johan.gant, if it's still required patch and works then you can set the status to Reviewed and Tested by the Community

@joelpittet good point, now done!

Hmm, not included in 3.15 as well.

Before we commit this, do we need to raise a separate issue for this in D8? Is it also a problem there?

I'm applying the patch on 3.16 again, this issue is for 7.x-3.x branch, can we have the patch implemented in the next release?

What would be good if we can update those steps to reproduce to work without DS and node reference if possible, then maybe it's something we can easily test in D8. Possible?

Restoring status so this doesn't get lost.

Might anyone have some time to turn the testing instructions into an actual test, so we can make sure this bug doesn't come back again?

Thank you.