Update the readme for how to use with the new version of ckeditor and implement hook: video_filter_ckeditor_plugin() [#1434158]

I'm not sure if i've made an error installing this module, but as far as i can see (and after inspecting the code) there is no support for setups using the ckeditor standalone module, ie:
http://drupal.org/project/ckeditor
(i'm currently on version 7.x-1.6)

I've made a start adding support; i've managed to register the plugin, however when ckeditor loads the button is not available. I assume something must be failing in plugin.js, but i'm not sure what.

Heres the code to register the plugin:

function video_filter_ckeditor_plugin() {
    return array(
        'video_filter' => array(
            // Name of the plugin used to write it.
            'name' => 'video_filter',
            // Description of the plugin - it would be displayed in the plugins management section of profile settings.
            'desc' => t('Video Filter plugin'),
            // The full path to the CKEditor plugins directory, with the trailing slash.
            'path' => drupal_get_path('module', 'video_filter') . '/editors/ckeditor/',
            'buttons' => array(
                'button_name' => array(
                    'icon' => 'video_filter.png',
                    'label' => 'Video filter',
                )
            )
        )
    );
}

I'm happy to help with supplying a patch to add this, if you / somebody can help spot the problem?

Cheers

Comment	File	Size	Author
#13	update_the_readme_for-1434158-13.patch	3.16 KB	kyletaylored
#13
#11	update_the_readme_for-1434158-11.patch	3.17 KB	helmo
#11
#9	video_filter-n1434158-9.patch	3.16 KB	DamienMcKenna
#9
#5	video_filter.code_.1434158-5.patch	2.85 KB	Yaron Tal
#5
#4	video_filter.code_.1434158-4.patch	2.43 KB	Yaron Tal
#4
#3	video_filter-ckeditor_readme-1434158.patch	2.48 KB	ttkaminski
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

VVS CreditAttribution: VVS commented 2 May 2012 at 17:17

For adding in standalone CKEditor see instruction in file: /sites/all/modules/video_filter/editors/ckeditor/README.txt

Comment #2

rooby CreditAttribution: rooby commented 12 September 2012 at 07:30

Title:	Support for ckeditor standalone module	» Update the readme for how to use with the new version of ckeditor
Category:	feature	» bug

I have followed the instructions and it doesn't seem to work.

The instructions seem to be for the older version of ckeditor, where you added buttons in a text field.
Now there is a fancy drag drop UI for adding buttons.

This worked for me (perhaps this can be added to the readme).

#1279042-2: Video Filter button not appearing in CKEditor

Comment #3

ttkaminski CreditAttribution: ttkaminski commented 1 February 2013 at 00:01

File	Size
video_filter-ckeditor_readme-1434158.patch	2.48 KB

Patch for updated instructions in README.txt based on #1279042-2: Video Filter button not appearing in CKEditor. Also updated the main video_filter README.txt to indicate where to find the ckeditor plugin.

Comment #4

Yaron Tal CreditAttribution: Yaron Tal commented 18 September 2013 at 11:31

Version:

7.x-3.0

» 7.x-3.x-dev

File	Size
video_filter.code_.1434158-4.patch	2.43 KB

Since the ckeditor also has a hook_ckeditor_plugins() we could also implement that to make it even simpler.
I updated the readme (taking the patch by @ttkaminski as a basis) to reflect this change and added the hook to the module.
This way you can leave the plugin in the module and there is no need to hack/patch/modify other modules or libraries.

Comment #5

Yaron Tal CreditAttribution: Yaron Tal commented 18 September 2013 at 11:37

Status:

Active

» Needs review

File	Size
video_filter.code_.1434158-5.patch	2.85 KB

Updated version of the patch to also reflect the change by @ttkaminski to the main readme file.

Comment #6

bibo CreditAttribution: bibo commented 29 April 2014 at 08:03

Title:	Update the readme for how to use with the new version of ckeditor	» Update the readme for how to use with the new version of ckeditor and implement hook: video_filter_ckeditor_plugin()
Status:	Needs review	» Reviewed & tested by the community

Thanks Yaron Tal, your patch in #5 worked perfectly. Ckeditor (4) now works as it should.

Comment #7

joep.hendrix CreditAttribution: joep.hendrix commented 3 July 2014 at 16:25

#5 Works fine.
Thanks all!

Please commit.

Cheers,
Joep

Comment #8

agileadam

Maine, USA

CreditAttribution: agileadam commented 10 September 2014 at 13:54

The patch in #5 allowed me to add the video filter plugin and button to the standalone CKEditor (after a cache clear).
There is apparently an issue in Chrome; as of right now clicking the button doesn't do anything. #2335169: Reliance on showModalDialog breaks CKEditor plugin in Chrome

Comment #9

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 21 November 2014 at 05:22

File	Size
video_filter-n1434158-9.patch	3.16 KB

3 files were hidden/shown/deleted

File	Size
video_filter-ckeditor_readme-1434158.patch	2.48 KB

video_filter.code_.1434158-4.patch	2.43 KB

video_filter.code_.1434158-5.patch	2.85 KB

Rerolled.

Comment #10

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 21 November 2014 at 05:39

Status:

Reviewed & tested by the community

» Needs work

The button shows in the CKEditor settings page, but it doesn't show on the editor itself.

Comment #11

helmo CreditAttribution: helmo commented 11 February 2015 at 15:11

Status:

Needs work

» Needs review

File	Size
update_the_readme_for-1434158-11.patch	3.17 KB

The path was missing a '/' to start with. The ckeditor.api.php example also adds this.

I've updated the patch to use base_path() for this, per the example of the media_wysiwyg module. Then it also works for Drupal sites installed in a subdirectory.

Comment #12

MrPeanut CreditAttribution: MrPeanut commented 27 July 2015 at 20:45

Patch from #11 applied cleanly, but I'm not seeing the button in "Available buttons" on my CKEditor profile (nor in the Plugins). Using CKEditor 7.x-1.16 (standalone).