Jump menu does work with cyrillic characters [#1466670]

when cities are written in Latin for example "Moscow". the jump menu works well by retrieving the right deals for the city.
But if i write it in Russian i.e (Москва) the result is false, meaning it bring the deals of all cities...

I did firebug and found out the url of Russian characters is converted to strange numbers

<option value="f027df09a334cf3e654a417aa17cdb33::/mysite/deals/%D0%B4%D0%BE%D0%B4%D0%BE%D0%BC%D0%B0">  
       Москва  </option>

but without russian the result is

<option value="4419c399e7ee0cbd1c85ce89ad8fef33::/mysite/deals/Moscow">  
          Moscow  </option>

So how do i correct this ?

Comment	File	Size	Author
#7	opendeals-cyrilliccharacters-1466670-6.patch	118.77 KB	nchar

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

mrcniceguy CreditAttribution: mrcniceguy commented 4 March 2012 at 12:06

I dont know if its good idea but now it is working after adding a line in views_plugin_style_jump_menu.inc file
just after $path = url($url_options['path'], $url_options);
i added this

$path=htmlspecialchars(strip_tags(urldecode($path)));

and now my urls are like this

<option value="773b222a704d56d7773a4e3b804596fd::/mysite/deals/москва">  москва  </option>

Comment #2

yannisc CreditAttribution: yannisc commented 29 August 2012 at 10:48

Status:

Active

» Needs review

Is this finally a working solution for you?

Comment #3

mrcniceguy CreditAttribution: mrcniceguy commented 29 August 2012 at 20:13

AS i said, am not sure if its best solution.
But it is working for me now.

Comment #4

yannisc CreditAttribution: yannisc commented 13 September 2012 at 05:56

Status:

Needs review

» Needs work

I confirm that the bug also exists with Greek city names.

This solution needs to hack the views module. We should find a way to make it work without having to hack modules or core.

Comment #5

yannisc CreditAttribution: yannisc commented 13 September 2012 at 05:57

Priority:

Normal

» Major

Comment #6

yannisc CreditAttribution: yannisc commented 13 September 2012 at 09:42

Status:

Needs work

» Fixed

We changed the way taxonomy filters deals to use taxonomy id instead of taxonomy name, so now it works with non-latin cities as well. Committed!

Comment #7

nchar CreditAttribution: nchar commented 13 September 2012 at 09:48

File	Size
opendeals-cyrilliccharacters-1466670-6.patch	118.77 KB

That was a difficult problem to solve. To fix this if you have already installed opendeals you need to apply the following patch at /profiles/opendeals. Then navigate to Structure > Features and revert "Opendeals Views" feature.

WARNING: If you have changed the settings of at least one opendeals' view then you must NOT revert this feature because you will lose your changes and you should change the view "cities_list" manually. Use a bare opendeals installation to view the changes.