Try this with this feature: http://waterfall.features.bkstg.artistarena.com/node/1.

Enable the feature. Make some changes to say one of the views. Then revert all the features. The flag component won't go to default status unless you go disable the flag itself.

If this is by design please explain. I am coming from the point of view that I want my features to be in their default state all the time to simplify deployment.

Thanks for the great module! Love it

Comments

ghankstef’s picture

ghankstef CreditAttribution: ghankstef commented

OK after digging into this some more, I see that my flag features configuration has code like this in it:

 // 'flag_confirmation' => 'blah blah blah blah blah!',
   // 'unflag_confirmation' => 'Click "Remove" to blah blah blah blah blah',

And commenting these out as about allows me to revert the feature. Hooray! I suspect that this ma be an artifact of updating from flag 1.x to 2.x but I'm not certain on that.

xtfer’s picture

xtfer CreditAttribution: xtfer commented

Im seeing the same issue, but there is no commented code in the export.

As viewed with the diff module, the features faux export doesn't appear to have the flag name in it, thus triggering the overridden state. Otherwise it seems to be up to date.

lpalgarvio’s picture

lpalgarvio CreditAttribution: lpalgarvio commented

i'm using 6.x-2.0-beta5

joachim’s picture

joachim CreditAttribution: joachim commented
Version: 6.x-2.0-beta5 » 7.x-3.x-dev
Component: Miscellaneous » Flag core

Needs checking on 3.x.

joachim’s picture

joachim CreditAttribution: joachim commented
Version: 7.x-3.x-dev » 7.x-2.x-dev

Works fine for me on 7.x-3.x.

Can someone try this out on 7.x-2.x?

joachim’s picture

joachim CreditAttribution: joachim commented
Title: Reverting features with flags leaves the feature in overriden mode » Flags in code can't be reverted to code

This is a deeper problem: there is no way to revert a flag to code, whether that is to undo UI customizations, or cause changed to the code to be reflected in the flag.

I think we're too far in 3.x to tackle this in clean ways (such as changing Flags to be CTools plugins).

However, I'm open to fixes for this that don't make huge structural changes to the code.