Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This blocks #1712250: Convert theme settings to configuration system
Problem
- The configuration system does not support themes, at all.
Comment | File | Size | Author |
---|---|---|---|
#5 | drupal8.config-theme-followup.patch | 1.34 KB | effulgentsia |
#1 | drupal8.config-theme.1.patch | 3.03 KB | sun |
Comments
Comment #1
sunAttached patch enables installation of default config for themes.
Current HEAD does not uninstall configuration for themes at any time, and I have a (rather critical) follow-up change to the uninstallation of configuration for modules in #1626584: Combine configuration system changes to verify they are compatible, so I'd like to work on proper uninstallation of config in a separate issue.
Comment #2
gddLooks good to my eyes, a straightforward but necessary change. Good catch.
Comment #3
Dries CreditAttribution: Dries commentedLooks good to me "three". Committed to 8.x.
Comment #5
effulgentsia CreditAttribution: effulgentsia commentedDoes this follow-up patch make sense? Discovered by attiks while working on #1775774: Allow themes to identify their breakpoints to Drupal.
Comment #6
sunBoth hunks make sense to me, but I'd really prefer to get #1067408: Themes do not have an installation status in first.
Comment #7
moshe weitzman CreditAttribution: moshe weitzman commentedLooks good.
Comment #8
attiks CreditAttribution: attiks commented#6 Can't we get this committed first, it's a very small patch?
Comment #9
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks!