|
batch_test_stack |
batch_test.module |
#1843410: Change variable batch_test_stack to the state system. |
|
|
block_test_caching |
block_test.module |
#1843420: Change block test variables - block_test_cache and block_test_content to state system |
|
|
block_test_content |
block_test.module |
#1843420: Change block test variables - block_test_cache and block_test_content to state system |
|
|
common_test_cron |
system.test |
|
|
|
dependencies |
system_test.module |
#1843442: Change the dependencies variable to the state system |
|
|
dependency_test |
module_test.module |
#1843452: Change dependency_test variable to state system. |
|
|
entity_cache_test |
entity.test |
#1843462: Change entity_test variables - entity_test_translation, entity_cache_test and entity_cache_test_label to the state system. |
|
|
entity_cache_test_label |
entity_cache_test_dependency.module |
#1843462: Change entity_test variables - entity_test_translation, entity_cache_test and entity_cache_test_label to the state system. |
|
|
entity_test_translation |
entity_test.module |
#1843462: Change entity_test variables - entity_test_translation, entity_cache_test and entity_cache_test_label to the state system. |
|
|
field_test_bundles |
field_test.entity.inc |
#1843476: Change field_test variables to state system. |
|
|
field_test_field_available_languages_alter |
field_test.module |
#1843476: Change field_test variables to state system. |
|
|
field_test_language_fallback |
field_test.module |
#1843476: Change field_test variables to state system. |
|
|
field_test_storage_data |
field_test.storage.inc |
#1843476: Change field_test variables to state system. |
|
|
file_test_hook_file_url_alter |
file_test.module |
#1843486: Change file_test variables to state system. |
|
|
file_test_results |
file_test.module |
#1843486: Change file_test variables to state system. |
|
|
file_test_return |
file_test.module |
#1843486: Change file_test variables to state system. |
|
|
front_page_output |
system_test.module |
#1848058: Change system test variables to the state system |
|
|
image_test_results |
image_test.module |
#1848058: Change system test variables to the state system |
|
|
language_test_content_language_type |
language_test.module |
#1843948: Change language test variables to the state system. |
|
|
language_test_domain |
language_test.module |
#1843948: Change language test variables to the state system. |
|
|
language_test_language_negotiation_info |
language_test.module |
#1843948: Change language test variables to the state system. |
|
|
language_test_language_negotiation_info_alter |
language_test.module |
#1843948: Change language test variables to the state system. |
|
|
language_test_language_negotiation_last |
LanguageNegotiationInfoTest.php |
#1843948: Change language test variables to the state system. |
|
|
language_test_language_types |
language_test.module |
#1843948: Change language test variables to the state system. |
|
|
menu_test_active_trail_initial |
menu.test |
#1843954: Change menu test variables to the state system. |
|
|
menu_test_hook_custom_theme_name |
menu_test.module |
#1843954: Change menu test variables to the state system. |
|
|
menu_test_menu_tree_set_path |
menu_test.module |
#1843954: Change menu test variables to the state system. |
|
|
menu_test_record_active_trail |
menu_test.module |
#1843954: Change menu test variables to the state system. |
|
|
openid_test_canonical_id_status |
openid_test.module |
#1848054: Change openid test variables to the state system. |
|
|
openid_test_hook_openid_response_account |
OpenIDFunctionalTest.php |
#1848054: Change openid test variables to the state system. |
|
|
openid_test_hook_openid_response_response |
OpenIDFunctionalTest.php |
#1848054: Change openid test variables to the state system. |
|
|
openid_test_identity |
|
#1848054: Change openid test variables to the state system. |
|
|
openid_test_redirect_http_reponse_code |
openid_test.module |
#1848054: Change openid test variables to the state system. |
the misspelling is in core |
|
openid_test_redirect_url |
openid_test.module |
#1848054: Change openid test variables to the state system. |
|
|
openid_test_request_alter |
|
#1848054: Change openid test variables to the state system. |
|
|
openid_test_response |
|
#1848054: Change openid test variables to the state system. |
|
|
path_test_results |
path.test |
#1848058: Change system test variables to the state system |
|
|
simpletest_bootstrap_variable_test |
bootstrap.test |
#1848058: Change system test variables to the state system |
|
|
test_module_enable_order |
system.test |
#1848058: Change system test variables to the state system |
|
|
test_verbose_module_hooks |
system_test.module |
#1848058: Change system test variables to the state system |
|
|
xmlrpc_test_xmlrpc_alter |
xmlrpc_test.module |
#1848066: Change variable xmlrpc_test_xmlrpc_alter to the state system. |
|
Comments
Comment #0.0
gddUpdated issue summary.
Comment #1
samhassell CreditAttribution: samhassell commentedFirst run at this hitting all the listed vars. No time to test it yet.
Comment #2
samhassell CreditAttribution: samhassell commentedComment #4
samhassell CreditAttribution: samhassell commentedtry again.
Comment #6
samhassell CreditAttribution: samhassell commentedComment #7
samhassell CreditAttribution: samhassell commentedComment #9
gddNote that the state system has not actually been committed yet, so this will continue to fail until that happens. The patch is still really useful though, it just can't be finished until the other issue goes in. Thanks for working on it!
Comment #10
samhassell CreditAttribution: samhassell commentedNever doing this without a testing environment again.. If it fails I'll come back tomorrow and fix.
Comment #11
samhassell CreditAttribution: samhassell commentedComment #13
dags CreditAttribution: dags commentedReplace "state()->del" with "state()->delete" and fix a couple missed conversions.
Comment #15
dags CreditAttribution: dags commented#13: convert-test-vars-to-state-system-1787218-13.patch queued for re-testing.
Comment #17
Lars Toomre CreditAttribution: Lars Toomre commentedI did not see this issue prior to opening #1814402: Convert 'node_access_test_private' variable to state() system. However, it was not included in the list in the summary.
Also opened #1813184: Convert variable 'tracker_index_nid' to state system for 'tracker_index_nid' variable conversion.
Comment #18
disasm CreditAttribution: disasm commentedHere's a reroll of #13.
Comment #19
disasm CreditAttribution: disasm commentedComment #20
disasm CreditAttribution: disasm commentedThe block test was a quick fix. Attached. Still failing OpenID and variable tests. The variable tests is going to need some refactoring (or maybe removal). It currently has a menu hook that that has a callback of variable_get in the system_test module.
Comment #21
disasm CreditAttribution: disasm commentedThe block test was a quick fix. Attached. Still failing OpenID and variable tests. The variable tests is going to need some refactoring (or maybe removal). It currently has a menu hook that that has a callback of variable_get in the system_test module.
Comment #22.0
(not verified) CreditAttribution: commentedUpdated issue summary.
Comment #23
ACF CreditAttribution: ACF commentedI think it makes more sense to tackle these variables with separate issues, particularly with some already having been done. I've made a start.
Comment #23.0
ACF CreditAttribution: ACF commentedAdding issue to batch_test_stack
Comment #23.1
ACF CreditAttribution: ACF commentedAdded issue for the block test variables.
Comment #23.2
ACF CreditAttribution: ACF commentedAdd issue for dependencies
Comment #23.3
ACF CreditAttribution: ACF commentedAdd issue for dependency test.
Comment #23.4
ACF CreditAttribution: ACF commentedAdd issue for entity test variables.
Comment #23.5
ACF CreditAttribution: ACF commentedAdd issue to field test variables.
Comment #23.6
ACF CreditAttribution: ACF commentedIssue for file test variables.
Comment #23.7
ACF CreditAttribution: ACF commentedLanguage variables issue.
Comment #23.8
ACF CreditAttribution: ACF commentedMenu test variables.
Comment #23.9
ACF CreditAttribution: ACF commentedopen id issue added
Comment #23.10
ACF CreditAttribution: ACF commentedsystem test variables
Comment #24
gddI thought it might be easy to do this all in one shot, but if some are already being worked on elsewhere I'll just close this one I guess. Lets make sure and keep #1775842: [meta] Convert all variables to state and/or config systems up to date.
Comment #24.0
gddxmlprc variable added.