Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Config entity in save assumed as updated when it's new
Probably there's no test, got this issue working on #1552396: Convert vocabularies into configuration
When vocabulary saved it's always displayed message about Update on new vocabulary
Comment | File | Size | Author |
---|---|---|---|
#10 | drupal-config-1789722-10.patch | 2.05 KB | tim.plunkett |
#6 | drupal-config-1789722-6.patch | 2.31 KB | tim.plunkett |
#4 | 1789722-core-save-4-test.patch | 1.34 KB | andypost |
#4 | 1789722-core-save-4.patch | 2.42 KB | andypost |
#2 | 1789722-core-save-2.patch | 1.08 KB | andypost |
Comments
Comment #1
andypostSimple fix
Comment #2
andypostFinally enforceNew() is moved too
Comment #3
webchickReally? how on earth can we not need tests for this? The logic was completely bass-ackwards.
Comment #4
andypostChanged a test to get this trouble
Attached 1789722-core-save-4-test.patch should fail
Comment #5
tim.plunkettI'm curious if this passes tests without this one line?
Comment #6
tim.plunkettD'oh.
Comment #8
tim.plunkettI don't fully understand that, I'll have to look at the tests tomorrow. Back to CNR for #4. Also, I didn't mean to change the priority.
Comment #9
andypostThis is a simple bug and there's already a test - Use patch from #4
let's get this in and continue with conversion to ConfigEntity patches
Comment #10
tim.plunkettDatabaseStorageController does the same thing, but in the reverse order. Here's a patch that is identical to #4 but with the order of the conditionals matching DatabaseStorageController.
I'd say this is RTBC.
Comment #11
andypost+1 RTBC and -1 to criticals, btw we should minimize commit thresholds to unfreeze commit features
Comment #12
sunLooks good to me.
Comment #13
webchickAwesome!!! :D Thanks so much for the quick turnaround on this.
Committed and pushed to 8.x.