Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
See #1781744: Draft and Needs review pages are broken for details and the workbench moderation patch.
Comment | File | Size | Author |
---|---|---|---|
#32 | 1792144-workbench-myedits-view.patch | 16.94 KB | hass |
#27 | workbench_edited_views-1792144-27.patch | 11.81 KB | asunko |
#27 | workbench_module-1792144-27.patch | 564 bytes | asunko |
#27 | workbench_access-1792144-27-do-not-test.patch | 840 bytes | asunko |
#27 | workbench_moderation-1792144-27-do-not-test.patch | 591 bytes | asunko |
Comments
Comment #2
hass CreditAttribution: hass commentedComment #3
hass CreditAttribution: hass commentedComment #4
hass CreditAttribution: hass commentedComment #5
hass CreditAttribution: hass commented@tkngdwn: Your patch is working great for me! THX!!!
Comment #6
teknic CreditAttribution: teknic commentedThis patch is applied against 7.x-1.x-dev, can we get a patch for 7.x-1.1?
Comment #7
hass CreditAttribution: hass commentedI have installed latest dev+patch and it fixed all. Dev looks stable... Just try it. There are no db changes. You may downgrade if all goes wrong.
Comment #8
bpironet CreditAttribution: bpironet commentedCould we get a patch for the 7.x-1.1?
Thank you very much in advance!
Comment #9
rv0 CreditAttribution: rv0 commentedPatch in #4 works fine for me on dev. Thank you!
The reason people are asking for a 1.1 patch is because the dev version is not available for download.
You need to use git or drush to get it.
Comment #10
hass CreditAttribution: hass commentedLatest DEV http://drupal.org/node/1081398
Comment #11
rv0 CreditAttribution: rv0 commentedbtw
With this patch, my workbench / my edits view now shows all content you edited (which is logical) but links to the content version instead of the node view (even on unversioned content)
So instead of "Link this field to its content revision" I chose "Link this field to the original piece of content" to fix it
This seems like a bug, so setting to "needs work".
Comment #12
Taxoman CreditAttribution: Taxoman commentedSeems like the following issue is resolved by the patch here:
#1630702: My Edits list contains multiple dupes
Comment #13
zunaeid CreditAttribution: zunaeid commentedThere are two typos for node_revision.
http://drupal.org/node/1735382
This worked for me. Thank you
Comment #14
agentrickardComment #12 creates a circular issue reference. Let's stay here. The other issue is closed.
Comment #15
hass CreditAttribution: hass commented@agendrickard: looks like you have co-maintainer permission. Are you able to review this and the moderation patch and get them committed? Both modules are not usable at all without. We need new releases asap.
Comment #16
stevectorhass, What's your opinion on #11? This issue is marked as "needs work."
Comment #17
hass CreditAttribution: hass commentedI have not tested this. I have the hope that the maintainers knows best.
Comment #18
agentrickard@hass
What moderation patch?
Comment #19
hass CreditAttribution: hass commentedThis one #1781744: Draft and Needs review pages are broken. Same topic, but only contains the Workbench part. Also critical.
Comment #20
agentrickardIn the -dev version, I'm not seeing this error anymore, which suggests that it has been fixed in Views.
I am seeing, however, two related issues:
Duplicate entries in the My Edits list.
Bad links to access denied on revisions.
This patch, I believe, incorporates the changes from #4 and also fixes those errors. Tested with Workbench 1.x-dev and Views 3.x-dev.
Comment #21
mrfelton CreditAttribution: mrfelton commentedPatch from #20 works for me. Thanks,
Comment #22
hass CreditAttribution: hass commentedIt looks like #1766338: Incorrect filter group OR behavior, LEFT JOIN changed to INNER JOIN is not yet fixed in Views and some thought this may be a reason.
Comment #23
agentrickardAs in "a reason why I just added an extra filter to correct duplicate records"?
Comment #24
hass CreditAttribution: hass commentedNo, it looks like a possible root cause for the original report in this case. I clicked trough all commit messages and until now (back to mid sept) I have not found any views commits to 7.x that may explain why the issue should be fixed. Just as a note. Haven't tried yet a views DEV.
Comment #25
asunko CreditAttribution: asunko commentedComment #27
asunko CreditAttribution: asunko commentedI have same problem that describe in this issue. These patches have helped to correct the work of three modules workbench 7.x-1.1, workbench access 7.x-1.0, workbench moderation 7.x-1.2 with module Views 7.x-3.5. I posted all of the patches in this issue. it works for me.
There are two options how to fix the problem of incompatibility workbench 7.x-1.1 and Views 7.x-3.5
Use one of them workbench_edited_views-1792144-27.patch or workbench_module-1792144-27.patch. The other two for workbench access 7.x-1.0 and workbench moderation 7.x-1.2 respectively.
These patches are for those who can't update listed above modules to dev version where I suppose this problem was fixed.
Comment #28
agentrickard@annasunko
Why did you do the following?
* Post multiple patches without any comment?
* Change the issue status?
* Change this to a support request?
* NOT REVIEW THE EXISTING PATCH?
While your intent may be to help, you are only confusing the issue.
Comment #29
asunko CreditAttribution: asunko commented@agentrickard
* Change the issue status?
* Change this to a support request?
Accidentally. The status has been returned.
Comment #30
agentrickardThanks.
The real blocker here is figuring out where these issues have been fixed (presumably in Views). My concern is that these patches will just break things again when a new Views release comes out.
Comment #31
hass CreditAttribution: hass commented@agentrickard: I'm running all modules (views, workbench, workbench_moderation, workbench_access) in latest DEV and I still see:
I'm not sure why your don't see this. Are you using taxonomy for permissions?
Comment #32
hass CreditAttribution: hass commentedShould we show unpublished, but edited content in the my edits list? I'm not sure. Otherwise the patch #20 from agentrickard also fixes the debug message. I'm marking RTBC now.
Re-attaching the patch #20 to remove the confusing failures from annasunko and get the green light again.
Comment #33
hass CreditAttribution: hass commentedComment #34
cweagansAre there no tests for Workbench? The test result is saying 0 passes, which makes me think "broken patch" (this happens in the core queue sometimes).
Comment #35
hass CreditAttribution: hass commentedNo, there are no tests yet. It just tests if the patch applies cleanly, has no unix line feeds and some other basic tests.
But you can write some tests... :-)
Comment #36
agentrickardWorkbench proper doesn't do much, so it has no tests. If there are good methods for testing that Views work, they could be applied here.
Comment #37
stevectorFixed. Thanks hass et al!
cweagans, "Workbench" does not have any tests, correct. Alone it does not do much. Workbench Moderation and Workbench Access do more of the heavily lifting and have some test coverage. That being said, tests on Workbench itself are welcome.
http://drupalcode.org/project/workbench.git/commit/85b13bbdb283fe6d910ac...
Comment #38
hass CreditAttribution: hass commentedGreat!
Comment #39
agentrickardAfter updating via Git and re-installing, I can no longer see the "Sections" column when using Workbench Access. But I see the filter.
Anyone seeing that?
Comment #40
agentrickardSee #1890632: Change machine name of title field so that Workbench Access can add its section column. for that last issue.
Comment #41.0
(not verified) CreditAttribution: commentedA