Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of meta #500866: [META] remove t() from assert message.
Comment | File | Size | Author |
---|---|---|---|
#13 | 1797328-13-t-image.patch | 50.82 KB | dcam |
#9 | image-1797328-9.patch | 51.02 KB | dcam |
#6 | image-1797328-6.patch | 50.76 KB | dcam |
#2 | image-1797328-2.patch | 38.57 KB | xjm |
Comments
Comment #1
xjmGuess I accidentally swapped two issues.
Comment #2
xjmComment #3
Lars Toomre CreditAttribution: Lars Toomre commentedIt helps to review issues in detail after some good sleep!! I have reviewed this patch in detail and can confirm that each of these changes to test t() assertion messages are correct. This patch includes some format_string() changes as well which are also correct.
With the bot also being happy, this is RTBC!
Comment #4
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks!
Comment #5
jhodgdonThis needs backporting to D7. Also, can someone confirm everything was fixed in D8 and move this back there if not?
Comment #6
dcam CreditAttribution: dcam commentedBackported #2 to D7.
Comment #7
dcam CreditAttribution: dcam commented#6: image-1797328-6.patch queued for re-testing.
Comment #9
dcam CreditAttribution: dcam commentedRerolled #6.
Comment #10
dcam CreditAttribution: dcam commentedTagging as Novice.
Comment #11
izus CreditAttribution: izus commented#9: image-1797328-9.patch queued for re-testing.
Comment #13
dcam CreditAttribution: dcam commentedRerolled #9.
Comment #14
izus CreditAttribution: izus commentedhi,
the patch looks good :)
thanks
Comment #15
jhodgdonThanks for all the retests, rerolls, and reviews! dcam/izus: you are on fire!
Committed to 7.x.