Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of meta #500866: [META] remove t() from assert message.
Comment | File | Size | Author |
---|---|---|---|
#15 | dblog-1797242-15.patch | 11.72 KB | dcam |
#12 | dblog-1797242-12.patch | 11.49 KB | dcam |
#9 | dblog-1797242-7.patch | 11.49 KB | dcam |
#7 | remove_t_from_dblog_tests_7.x-1797242-7.patch | 11.48 KB | lazysoundsystem |
#1 | dblog-1797242-1.patch | 11.12 KB | xjm |
Comments
Comment #1
xjmAnother tiny one.
git diff --color-words
Comment #2
Lars Toomre CreditAttribution: Lars Toomre commentedAgain I check each of these message sting changes and all are appropriate. Let's wait for the bot to come back green, but these changes look good to go.
Comment #3
Lars Toomre CreditAttribution: Lars Toomre commentedThis is ready to go!! RBTC
Comment #4
xjmComment #5
jhodgdonThis one's in! Time for 7.x.
Comment #6
jhodgdonoops.
Comment #7
lazysoundsystem CreditAttribution: lazysoundsystem commentedHere's for 7.x
Comment #9
dcam CreditAttribution: dcam commentedBackported #1 to D7.
Edit: Sorry for the crosspost. I wouldn't have written another D7 patch had I noticed lazysoundsystem's #7.
Comment #11
jhodgdonThis patch (#9) is failing with this error:
That's a typo -- format_text() [does not exist] vs. format_string() [correct function] :
#7 has a different error (database query error)... seems like #9 will be easier to fix.
Comment #12
dcam CreditAttribution: dcam commentedFixed the function error in #9.
Comment #13
dcam CreditAttribution: dcam commented#12: dblog-1797242-12.patch queued for re-testing.
Comment #15
dcam CreditAttribution: dcam commentedRerolled #12.
Comment #16
dcam CreditAttribution: dcam commentedTagging as Novice.
Comment #17
izus CreditAttribution: izus commented#15: dblog-1797242-15.patch queued for re-testing.
Comment #18
izus CreditAttribution: izus commentedhi,
the patch seems good
Thanks
Comment #19
dcam CreditAttribution: dcam commentedThanks for the review, izus!
Comment #20
jhodgdonThanks all! Committed to 7.x and this one is done!