Hide shared form elements when the user has not the related permission

This has been rolled while working on #1280546: Introduce a language selection widget for every entity thus won't apply to HEAD until that one is committed.

Reviews welcome anyway.

Now we are ready for bot review.

#3 was addressing two completely different issues in one patch. I split them: #1799770: Update id and bundle when setting a wrapped entity.

Committed and pushed the relevant part.

You are right, there is an inconsistency: I think one should be allowed to edit shared fields only if she has the related permission, we will then have an #1770748: Option to display shared fields only when editing the original values to match the current field behavior.

+++ b/includes/translation.handler.inc
@@ -1075,20 +1075,37 @@ class EntityTranslationDefaultHandler implements EntityTranslationHandlerInterfa
+   * Fields are handled separately in entity_translation_field_attach_form().

Can we handle everything here? I don't think we have a particular reason to deal with fields in a separate place, and that makes the logic harder to follow.

+++ b/includes/translation.handler.inc
@@ -1075,20 +1075,37 @@ class EntityTranslationDefaultHandler implements EntityTranslationHandlerInterfa
+  private function entityFormSharedElements(&$form) {

Why private?

+++ b/includes/translation.handler.inc
@@ -1075,20 +1075,37 @@ class EntityTranslationDefaultHandler implements EntityTranslationHandlerInterfa
+    $ignored_elements = array_flip(array('language', 'translation'));

This should not be needed, as the language widget and the translation settings do have an #access key.

+++ b/includes/translation.handler.inc
@@ -1075,20 +1075,37 @@ class EntityTranslationDefaultHandler implements EntityTranslationHandlerInterfa
+        $form[$key]['#translatable'] = FALSE;

This looks promising, however I think in the future we will need a more reliable way to determine whether a widget is multilingual or not, and enforce shared access based on that, even if we already have an #access key. I'm thinking about a '#multilingual' key instead of '#translatable' (which is more specific) that we would assign to core form elements (fields included) and we would ask other modules to provide to integrate with ET. It would simply be ignored if ET is not installed. This must be a follow-up though, as we need to ensure modules actually accept this integration stuff.

This is already planned for D8, btw: #1498724: Introduce a #multilingual key (or similar) for form element.

Marked that one duplicate. Let's not forget about crediting @Berdir in the changelog and commit message.

Working on this.

The attached patch fixes #10 and adjusts the update function 7002 to cover also shared fields permissions.

Actually we want to prevent access only to the entity form fields: hook_field_access() was too much.