I am not sure if this is an issue but I noticed that the path mentioned is incorrect.

Currently it is: admin/config/services/aggregator

But it should be admin/config/services/aggregator/settings

All the path mentioned in the aggregator.api.php point to admin/config/services/aggregator so I am not sure if this is an issue or not.

If it is please let me know and I can create a patch.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhodgdon’s picture

Version: 7.x-dev » 8.x-dev
Issue tags: +Novice, +Needs backport to D7

Thanks! The page in question is:
http://api.drupal.org/api/drupal/modules!aggregator!aggregator.api.php/f...

I think we should probably remove the admin path from the documentation entirely -- our standard in general is not to include specific paths in documentation (for instance, in page callbacks from hook_menu()) because they change too much and the docs don't get updated (as in this case).

Ivan Zugec’s picture

Status: Active » Needs review
FileSize
3.14 KB

Here's a first pass at cleaning up the API documentation.

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

THANK YOU, this is perfect. I'll get it committed shortly.

jhodgdon’s picture

Assigned: Unassigned » jhodgdon

assigning to self for commit so webchick doesn't get overwhelmed by the RTBC queue. :)

jhodgdon’s picture

Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed to 8.x. Needs to be ported to 7.x now. Thanks!

jhodgdon’s picture

Assigned: jhodgdon » Unassigned
Ivan Zugec’s picture

Status: Patch (to be ported) » Needs review
FileSize
4.01 KB

Awesome. Here's a patch for Drupal 7.

jhodgdon’s picture

Status: Needs review » Needs work

There are some spacing and wrapping problems in the last block of this patch:

+ * The title and the description provided are shown  within the
+ * configuration page. Use as title the natural name of the processor and as
+ * description a brief (40 to 80 characters) explanation of the functionality.

(two spaces before "within", and "configuration" will fit on the previous line. Other than that, looks good, thanks!

Ivan Zugec’s picture

Fixed patch as requested.

Ivan Zugec’s picture

Status: Needs work » Needs review
jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Looks ready to commit when the test bot comes back green, thanks!

jhodgdon’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 7.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.