testDrupalPreRenderLinks() uses DOMDocument().
Anything using assertThemeOutput uses assertIdentical() on check_plain(var_export($output, TRUE))
And now #1038932-43: theme_image_formatter() assumes that title, alt, and options are always set is creating a menu callback and using xpath.
Ideally you would know the EXACT expected output, but in D7 any theme function that generates a link will need a workaround for clean URLs.
Comment | File | Size | Author |
---|---|---|---|
#13 | drupal-1706878-13.patch | 2.04 KB | tim.plunkett |
#8 | drupal-1706878-8.patch | 1.03 KB | lazysoundsystem |
#6 | drupal-1706878-6.patch | 1.02 KB | lazysoundsystem |
#2 | drupal-1706878-2.patch | 3.1 KB | tim.plunkett |
#1 | drupal-1706878-1.patch | 3.09 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettThis would certainly be a start.
Comment #2
tim.plunkettChange the t() to format_string() to match our code standards.
Comment #3
sunThanks! Clarifying title.
Comment #4
tim.plunkettMight as well backport this.
Comment #5
catchLooks good to me. Committed/pushed to 8.x.
Some other tests may have copied assertThemeOutput() already but I think it's probably safe to backport, up to David and Angie anyway.
Comment #6
lazysoundsystem CreditAttribution: lazysoundsystem commentedWhile updating #983528: support $group and $message parameters in all assert() functions for D8, I noticed that this test doesn't return anything.
I've added that in a patch against the already committed version.
Comment #7
andypostThere should be a blank line before @return
Comment #8
lazysoundsystem CreditAttribution: lazysoundsystem commentedThanks @andypost, good point. I'll get the hang of this one day...
Comment #9
andypostGood to go
Comment #10
Lars Toomre CreditAttribution: Lars Toomre commentedIn the future, please add type hinting to all @param and @return directives for any docblock you update. Thanks.
Comment #11
Lars Toomre CreditAttribution: Lars Toomre commentedWhoops... did not mean to change status.
Comment #12
webchickDoesn't look like anything else in that file has type hinting, so probably best to handle that in a separate patch as part of the larger clean-up effort. It would be weird to introduce that here and nowhere else in the file/function.
Committed and pushed follow-up to 8.x. Back to 7.x. Should be harmless to backport. Re-classifying as a feature request though.
Comment #13
tim.plunkettComment #14
tstoecklerStraight backport.
Comment #15
David_Rothstein CreditAttribution: David_Rothstein commentedNot sure if it's a feature request or a task, but either way it looks good :)
Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/eb1be63
Comment #16
David_Rothstein CreditAttribution: David_Rothstein commentedNo idea why the "7.18 release notes" tag fails to show up on the issue half the time I add it in a comment... trying again.
Comment #17
David_Rothstein CreditAttribution: David_Rothstein commentedDrupal 7.18 was a security release only, so this issue is now scheduled for Drupal 7.19 instead.
Fixing tags accordingly.
Comment #19
David_Rothstein CreditAttribution: David_Rothstein commentedDrupal 7.19 was a security release only, so this issue is now scheduled for Drupal 7.20 instead.
Fixing tags accordingly.
Comment #20
David_Rothstein CreditAttribution: David_Rothstein commentedDrupal 7.20 was a security release only, so this issue is now scheduled for Drupal 7.21 instead. For real this time... I think :)
Fixing tags accordingly.
Comment #21
David_Rothstein CreditAttribution: David_Rothstein commentedTrying to fix the tags again...
Comment #22
David_Rothstein CreditAttribution: David_Rothstein commentedFixing tags since Drupal 7.21 only contained a fix to deal with fallout from the Drupal 7.20 security release. Hopefully this is really the last time I do this and this will be released in Drupal 7.22 for real :)