Missing spaces before and after the accessible markup on facet links [#1809040]

The accessible markup on inactive facet links is missing a space between the link text and the accessible markup. So from the point of view of a screen reader, it will appear as something like "TextApply Text filter", with the first two words running together.

Comment	File	Size	Author
#2	facetapi-accessible-markup-missing-space-1809040-2.patch	812 bytes	David_Rothstein
#2
#1	facetapi-accessible-markup-missing-space-1809040-1.patch	529 bytes	David_Rothstein
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

David_Rothstein CreditAttribution: David_Rothstein commented 10 October 2012 at 18:57

Status:

Active

» Needs review

File	Size
facetapi-accessible-markup-missing-space-1809040-1.patch	529 bytes

Here is a patch.

Comment #2

David_Rothstein CreditAttribution: David_Rothstein commented 10 October 2012 at 23:26

Title:

Missing space before the accessible markup on inactive facet links

» Missing spaces before and after the accessible markup on facet links

File	Size
facetapi-accessible-markup-missing-space-1809040-2.patch	812 bytes

Actually it seems like for active links there can be a missing space after the accessible markup instead.

So rather than trying to figure this out exactly, here's a new patch that just makes the accessible markup have spaces before and after, always. That way it will work regardless of what's around it. And as long as the spaces are part of the accessible markup (and invisible) they won't disrupt any layouts.

Comment #3

cpliakas CreditAttribution: cpliakas commented 12 October 2012 at 11:50

Issue tags:

+Accessibility

Hi David.

Thanks for the patch! Unfortunately I don't fully understand the implications of this, but I will take your word for it. As long as it doesn't change the layout, then your reasoning makes sense and I am happy to commit this patch. I would love to get some feedback from the Drupal accessibility wizards as well.

Thanks for the contribution!
Chris