Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
This seems to be an issue with drupal_get_form() being passed straight in to drupal_render()
e.g. $o = drupal_render(drupal_get_form('stormproject_list_filter', $filterdesc));
Comment | File | Size | Author |
---|---|---|---|
#10 | storm-1799432-drupal_render.patch | 4.65 KB | willwh |
#9 | storm-1799432-drupal_render-9.patch | 4.65 KB | juliangb |
#5 | 1799432-drupal_render-4.patch | 9.53 KB | willwh |
#1 | storm-drupal_render-1799432-2.patch | 9.66 KB | willwh |
Comments
Comment #1
willwh CreditAttribution: willwh commentedHere's a very simple patch for these - is this the correct way to deal with this? :)
Comment #2
kfritscheI wonder that this works with D6 :P
But this should be the correct way.
Comment #3
juliangb CreditAttribution: juliangb commentedSensible change - but could we get rid of the trailing whitespace please?
Comment #4
juliangb CreditAttribution: juliangb commentedJust tried to redo this myself, and found the patch file is corrupted.
Are you able to repost at all?
Comment #5
willwh CreditAttribution: willwh commentedSure thing, should have removed whitespace too :)
Comment #6
juliangb CreditAttribution: juliangb commentedWilliam,
I'm still having some trouble reading (machine reading!) your patches - were they created using the process described at http://drupal.org/node/707484?
Also noticed the testbot says that no files were affected by the patch - means that it isn't reading them either!
Might have come back to these before your part of the world wakes up, but happy to help figure out what's going on here.
Thanks,
Julian
Comment #7
willwh CreditAttribution: willwh commentedHi julian, I'm using powershell in windows, git diff 7.x-.1x > whatever.patch
I'll try making patches straight from eclipse - or just jump over to a nix box and work from there :)
p.s. still haven't seen you in IRC ;)
Comment #8
juliangb CreditAttribution: juliangb commentedAh windows... might be the line endings.
[snip from the handbook]
Line endings and directory separators
Note for Windows users: Use Unix line endings (LF) and directory separators (/). Many text editors can convert line endings, or you can pipe
diff
output throughdos2unix
.[/snip]
Comment #9
juliangb CreditAttribution: juliangb commentedLet's try this one.
Comment #10
willwh CreditAttribution: willwh commentedLet's try again :)
Comment #11
juliangb CreditAttribution: juliangb commentedCommitted - thanks!