Even if subcategories have nodes, main category count is still zero.

PS : Main category's page (therefore unreachable) shows correctly subcategories nodes.

CommentFileSizeAuthor
#8 categorycount-1593570-8.patch2.62 KBdaffodilsoftware
#6 categorycount-1593570-6.patch2.62 KBdaffodilsoftware
#4 categorycount-1593570-4.patch2.67 KBdaffodilsoftware
#1 site_map-count_children-1593570-1.patch2.43 KBAvorathol
site-map-count-0.png3.32 KBAvorathol
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Avorathol’s picture

Avorathol CreditAttribution: Avorathol commented
Priority: Major » Normal
Status: Active » Needs review
FileSize
site_map-count_children-1593570-1.patch2.43 KB

Patchfile for count children against 7.x-1.x branch. It adds a configuration option and count children if specified.

darrell_ulm’s picture

darrell_ulm CreditAttribution: darrell_ulm commented

Thanks very much for the patch Avorathol. Hope to test and apply soon.

darrell_ulm’s picture

darrell_ulm CreditAttribution: darrell_ulm commented
Status: Needs review » Needs work

Avorathol,

The patch does not apply, can you check and/or fix and re-post?

File to patch: site_map.module
patching file site_map.module
Hunk #1 succeeded at 435 with fuzz 1 (offset -75 lines).
Hunk #2 FAILED at 604.

Thank you,

daffodilsoftware’s picture

daffodilsoftware CreditAttribution: daffodilsoftware commented
FileSize
categorycount-1593570-4.patch2.67 KB

Avorathol,
I also tried the patch that you created but it failed.I reworked on your code to get it functional and thus created a new patch so Avorathol/darrellulm Please test it and give your reviews.

frjo’s picture

frjo CreditAttribution: frjo commented
Assigned: Unassigned » daffodilsoftware

Please rework the patch so it follows the Drupal coding standard.

http://drupal.org/coding-standards

Use an indent of 2 spaces, with no tabs for example.

daffodilsoftware’s picture

daffodilsoftware CreditAttribution: daffodilsoftware commented
FileSize
categorycount-1593570-6.patch2.62 KB

Sorry It was my mistake there was only one problem of a trailing whitespace.adding the patch again

frjo’s picture

frjo CreditAttribution: frjo commented

I'm afraid there are a number of other coding standard problems with the patch. Mostly these http://drupal.org/coding-standards#controlstruct.

daffodilsoftware’s picture

daffodilsoftware CreditAttribution: daffodilsoftware commented
FileSize
categorycount-1593570-8.patch2.62 KB

I revised the patch as recommended.And here it goes.couple of braces were misplaced right?

darrell_ulm’s picture

darrell_ulm CreditAttribution: darrell_ulm commented

This is the largest patch, I should have tested this one 1st, but it didn't work out that way. Committed another one of your patches which makes this one not apply. Are you willing to do a quick re-roll of you have all the sources avail? Thanks!

If this one passes, we ought to apply it 1st as it has the most changes.

darrell_ulm’s picture

darrell_ulm CreditAttribution: darrell_ulm commented
Issue summary: View changes
Status: Needs work » Needs review