Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Move path_alias_whitelist to the state system
Move variable_get/_set/_delete to state()->get/set/delete
Comment | File | Size | Author |
---|---|---|---|
#11 | path_alias_whitelist-1798884-11.patch | 1.78 KB | alexpott |
#8 | path_alias_whitelist-1798884-8.patch | 2.01 KB | alexpott |
#7 | path_alias_whitelist-1798884-7.patch | 1.06 KB | alexpott |
#5 | path_alias_whitelist-1798884-5.patch | 2.01 KB | Luukyb |
#1 | path_alias_whitelist-1798884.patch | 1.3 KB | Luukyb |
Comments
Comment #1
Luukyb CreditAttribution: Luukyb commentedComment #2
Luukyb CreditAttribution: Luukyb commentedComment #3
alexpottThe variable needs removing during Drupal 7 to 8 upgrade. See http://drupal.org/node/1787318 for how to do this.
Comment #4
alexpottComment #5
Luukyb CreditAttribution: Luukyb commentedOk cool, I added the namespace to the variable and the system_update function.
Thanks for reviewing.
Comment #6
Luukyb CreditAttribution: Luukyb commentedComment #7
alexpottLooks good - bumped update to system_update_8028()
Comment #8
alexpottThe patch attached to #7 was bogus... not sure what happened there.
Anyhow... patch in #6 still looks good - just bumped update to system_update_8028()
Comment #9
webchick8029* ;) Been a busy night!
Committed and pushed that (with the renumbering, and also a > 80 chars comment fix).
Comment #10
Lars Toomre CreditAttribution: Lars Toomre commentedI think that there was a problem with this patch. There is no second parameter in calls to state()->get.
If I understand correctly, variable_get('my_data', 'bar') should become:
As a result, I am setting this back to needs work for the correction(s).
Comment #11
alexpottAnd the upgrade is unnecessary :)
Comment #12
alexpottComment #13
alexpottbtw... no need to provide a default as NULL will be return by the state system if it's not set... which is the same as the default.
Comment #14
aspilicious CreditAttribution: aspilicious commentedComment #15
catchThis shouldn't really be in the state system, it's a cache, it just happens to be a cache that's /extremely/ expensive to rebuild so it was stuffed into variables.
I'd rather do #1209226: Avoid slow query for path alias whitelists (which was getting a lot closer last time I looked).
Comment #16
catchThis shouldn't really be in the state system, it's a cache, it just happens to be a cache that's /extremely/ expensive to rebuild so it was stuffed into variables.
I'd rather do #1209226: Avoid slow query for path alias whitelists (which was getting a lot closer last time I looked).
Comment #17
miro_dietikerPostponing, hope the other issue will fix it. The other first.
#1209226: Avoid slow query for path alias whitelists
Comment #18
sunNot sure what the proper component for this is, but configuration system isn't. :)
Comment #19
BerdirAlso, I think this was already done as part of the alias/path refactoring.