When I edit a node with a translated file (image) and I click on Edit Media, I expect to be able to edit the translated version of that entity, not the original.
- I've a content type Article with a Dutch translation.
- I've enable translations for the entity File and created a Dutch translation for a specific image
- While in the English interface, I've added the image to a node.
- When I switch the interface to Dutch I see the translated node and even the translated image beloning to the node
- When I EDIT the node, I have a button 'Edit media' (see screenshot). This opens a modal frame with a form to edit the image. This form however, shows the english version of the image. Not the Dutch version, as I expected.
See screenshot.
Comments
Comment #1
africavi CreditAttribution: africavi commentedSubscribe,
I`have the same issue on file entities. I have an image file entities with some attached fields in french (I use Media with entity translation). when I add an image and translate it to english, all go well. but if I want to edit the translation, the edit form display the source entity that in french ?
Comment #2
plachThis should be fixed once #1282018: Improve UX of language-aware entity forms is committed.
Comment #3
plachDoes not work properly yet. Let's fix this.
Comment #4
plachWe need better integration with the Media project.
Comment #5
plachRelated issue: #1418076: Allow for multiple base paths.
Comment #6
bforchhammer CreditAttribution: bforchhammer commented[double post removed]
Comment #7
bforchhammer CreditAttribution: bforchhammer commentedAttached patch (against media-7.x-2.x) adds ET support for the media edit modal popup, with the multiple-paths patch in #1418076-18: Allow for multiple base paths... We should probably open a new issue in the media issue queue once the multiple path issue is resolved.
Comment #8
plachThe attached patch adds ET integration for the Media modal popup (requires #1418644-7: Add multilingual support for files and #1418076-22: Allow for multiple base paths).
Comment #9
plachBetter UX: now the link to create a translation uses the canonical local action theming. Moreover now it is possible to create a translation only in if it is missing the current content language. This way context is always kept and pressing the 'Edit media' button allows to edit the values for the current language or create a translation for the current language. Full administration of translations is still available at
file/%file/translate
.Comment #10
plachAhem
Comment #11
plachMinor fix.
Comment #12
plachThis and #1418644: Add multilingual support for files are the last blockers for the first Entity Translation beta. It would be great to have some feedback ASAP :)
Comment #13
bforchhammer CreditAttribution: bforchhammer commentedAwesome, patch #11 works very well and makes translating media files soooo much easier! :)
I only have two questions/issues and think it's RTBC otherwise:
This is only for the "file/x/edit" pages, right? For the media path scheme it doesn't do anything because the "delete translation" action is removed anyway... So does this belong into media or should it be in file_entity?
Can we reuse some existing theming function for this?
Comment #14
plachNice catch :) This actually would belong to File Entity, but I thought it didn't make sense to introduce a
FileEntityTranslationHandler
just for those two lines. Do you think it's worth?I wasn't able to find a proper theming function. See Bartik's page.tpl.php.
Comment #15
bforchhammer CreditAttribution: bforchhammer commentedNo, I guess not. Let's leave it in here for now. (Unless media module maintainers object?)
Hm, looks like there's no theming function for the list then, but we can use 'menu_local_action' for the link... patch updated.
Comment #16
plachWorks for me.
Comment #17
bforchhammer CreditAttribution: bforchhammer commentedUpdated the patch for the change introduced in #1799770: Update id and bundle when setting a wrapped entity (removed
$entity_id
from handler constructor).Comment #18
plachThat was the last serious API change for Entity Translation before beta1. You can commit #17 safely, if you are happy with it.
Comment #19
ParisLiakos CreditAttribution: ParisLiakos commentedI am happy with it, thought at first that this should be in file entity module, but i see this is about media path.
thanks both
Comment #21
mahalo13 CreditAttribution: mahalo13 commentedthe problem still occurs also in the latest Dev-Version.
My Image Entity has 3 Fields (Title, Alt and Caption). If I edit a Node an click on the Edit Button for the Image, it does not pass the current Form Language so that the Fields can be edited in the actual form language.
Is there any Workaround or Solution?
Comment #22
mahalo13 CreditAttribution: mahalo13 commentedPlease see comment #21
Comment #23
ParisLiakos CreditAttribution: ParisLiakos commentedplease open a new issue, this one is long dead now
Comment #24
tobiberlinAlthough this issue was already re-closed I re-re-open it as I found out that the patch provided here was not fully adopted to the current alpha-4 version.
In the media.module file in line 71 you find the following:
but it needs to be
Comment #25
pmusaraj CreditAttribution: pmusaraj commentedI am running into this issue as well. If I add the line in comment 24, the translation works for fields, but not for the wysiwyg.
Comment #26
ParisLiakos CreditAttribution: ParisLiakos commented#23
Comment #27
Jody LynnPatch version of comment 24 attached
Comment #28
BerdirOpened #2707131: Add missing media path scheme for entity translation with the patch from #27.