Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
This is a sub-task of #500866: [META] remove t() from assert message focused on the Update module.
In D8 per http://drupal.org/simpletest-tutorial-drupal7#t, best practice is to remove t() from assert messages in tests. When necessary, t() should be replaced with format_string().
There are approximately 23 changes needed in 4 Test files. This issue includes conversion of all format_patch() occurances as well (none were needed).
Comment | File | Size | Author |
---|---|---|---|
#4 | 1798384-4-t-update.patch | 8.93 KB | dcam |
#1 | 1798384-1-t-update.patch | 10.54 KB | Lars Toomre |
Comments
Comment #1
Lars Toomre CreditAttribution: Lars Toomre commentedHere is an initial untested patch for this issue.
Comment #2
dcam CreditAttribution: dcam commented#1 looks good to me. I don't notice any additional t()'s around assert messages.
Comment #3
jhodgdonThanks! Committed to 8.x. Ready for backport...
Comment #4
dcam CreditAttribution: dcam commentedBackported #1 to D7.
Comment #5
dcam CreditAttribution: dcam commented#4: 1798384-4-t-update.patch queued for re-testing.
Comment #6
dcam CreditAttribution: dcam commentedTagging as Novice.
Comment #7
Mile23The patch in #4 applies cleanly to 7.x-dev, and I don't see any t()-wrapped assertion messages.
Comment #8
jhodgdonThanks, and sorry for the delay -- committed to 7.x.
Comment #9.0
(not verified) CreditAttribution: commentedModified initial counts.