Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I'm testing Flag on a client site, and if I set a user to be able to reset abuse flags,
print flag_create_link('abuse_node', $node->nid);
it no longer allows them to flag content. They only get the "reset flags" link.
Comment | File | Size | Author |
---|---|---|---|
#10 | flag-abuse-remove-reset.patch | 8.44 KB | ezra-g |
Comments
Comment #1
tanjerine CreditAttribution: tanjerine commentedsubscribing. i've been wondering about this too.
[edit]
Barry: I'm not sure if this will work for you, but I disabled all the default flags and re-created them and I am now seeing the 'flag content' links.
Comment #2
BarryHoggard CreditAttribution: BarryHoggard commentedThanks for the info, but I'm concerned about what happens with upgrades if it's not working now without deleting and re-creating things.
Comment #3
quicksketchSounds like this should have been filed in the Flag Abuse queue.
Comment #4
Thomas_Zahreddin CreditAttribution: Thomas_Zahreddin commentedsame here, complex site with many modules:
flags work, but not flag_abuse:
only for users the flag-link is visible after creating the flag manualy as #1 suggests.
But for the admin-users the the Reset -> Abuse is not shown.
Comment #5
ezra-g CreditAttribution: ezra-g commentedI'm experiencing this issue with 7.x-2.x dev as well.
Comment #6
ryank76 CreditAttribution: ryank76 commentedGetting this for 6.x-2.0-rc1
Comment #7
ezra-g CreditAttribution: ezra-g commentedThis appears to be related to
It seems we'd want to provide an *additional* link to reset all flags rather than overriding the existing link to flag content.
Comment #8
ezra-g CreditAttribution: ezra-g commentedMarked #1530214: In views node flag abuse shows Reset flags instead of Flag abuse link as a duplicate.
I think we should consider removing the reset functionality (since it appears to not work in its own right) and file an issue for bringing it back in.
Comment #9
ezra-g CreditAttribution: ezra-g commentedComment #10
ezra-g CreditAttribution: ezra-g commentedThe "reset all flags on this item" feature appears to be based on #571100: Add "reset" action and hooks to Flag (now fixed), though that functionality in Flag.module lacks a UI per #823314: Flag Reset Links/UI.
The default flag exports in flag_abuse module attempt to make use of this functionality by adding a 'reset' to the list of events:
They appear to also set Flag properties that aren't yet exposed by the Flag UI:
It appears that Flag abuse attempts to reset all "flag this content" link for its flag types with reset links but
A) That removes the ability for users with the "reset flags" permission to flag content
B) It appears to do so in a way that's not recognized by flag.
I'll try to evaluate the work necessary to fix the reset implementation versus just removing it from Flag abuse and letting it be re-introduced as a feature request.
I rolled a quick patch to remove the reset functionality for the time being, which should restore the fundamental functionality of Flag Abuse for users who lost it due to this issue.
Leaving as "active" rather than "needs review" pending an assessment of fixing the reset functionality rather than removing it.
Comment #11
ezra-g CreditAttribution: ezra-g commentedGiven that the reset functionality:
- Is causing bug in the module that is major to critical
- Requires non-trivial refactoring in order to be implemented in a scalable way (#1074242: Re-introduce whitelisted content) and that this refactoring is similar in scope to a re-implementation anyway
I propose we commit the patch in #10, remove the "reset" functionality and re-introduce it as part of #1074242.
Comment #12
sirkitree CreditAttribution: sirkitree commentedagreed, though I don't have time atm to review the actual code.
Comment #13
ezra-g CreditAttribution: ezra-g commentedThis is committed.
http://drupalcode.org/project/flag_abuse.git/commit/b425454
Comment #15
MustangGB CreditAttribution: MustangGB commented