Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Cameron Tod’s picture

Status: Active » Needs review
FileSize
2.14 KB

And here is a patch. Tests are passing locally.

alexpott’s picture

Status: Needs review » Needs work
+++ b/core/modules/openid/lib/Drupal/openid/Tests/OpenIDFunctionalTest.phpundefined
@@ -88,7 +88,9 @@ function testDiscovery() {
+    $config = config('openid.settings');
+    $config->set('xri_proxy_resolver', url('openid-test/yadis/xrds/xri', array('absolute' => TRUE)) . '/');
+    $config->save();

This could be written like this...

config('openid.settings')
  ->set('xri_proxy_resolver', url('openid-test/yadis/xrds/xri', array('absolute' => TRUE)) . '/')
  ->save();
Cameron Tod’s picture

Status: Needs work » Needs review
FileSize
1.24 KB
2.1 KB

Standards cleanup from #2.

alexpott’s picture

Status: Needs review » Needs work

Needs an hook_update_N function to migrate the variable from a Drupal 7 site.

Cameron Tod’s picture

Status: Needs work » Needs review
FileSize
488 bytes
2.66 KB

Added upgrade path.

Cameron Tod’s picture

Removed extra trailing carriage return.

alexpott’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Configuration system

Works as expected. Thanks for the work.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.