Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
This is a child of #1775842: [meta] Convert all variables to state and/or config systems
Note that there is some discussion around this variable in #721400: Order JS files according to weight, don't change filenames for aggregated JS/CSS also.
Comment | File | Size | Author |
---|---|---|---|
#6 | 1824854-cmi-drupal_stale_file_threshold-6.patch | 1.36 KB | Cameron Tod |
#6 | interdiff.txt | 506 bytes | Cameron Tod |
#5 | 1824854-cmi-drupal_stale_file_threshold-5.patch | 1.36 KB | Cameron Tod |
#3 | 1824854-cmi-drupal_stale_file_threshold-3.patch | 1.47 KB | Cameron Tod |
#3 | interdiff.txt | 441 bytes | Cameron Tod |
Comments
Comment #1
Cameron Tod CreditAttribution: Cameron Tod commentedComment #2
Cameron Tod CreditAttribution: Cameron Tod commentedCandidate patch attached. Couple of things:
- New state name is `system.stale_file_threshold`, but I'm not sure this is the best name. It might be better to put it in the file namespace, maybe?
- I've added a general purpose update hook to convert variables to the state system. I'm not sure if this is within the scope of the patch, but at the least it will convert any saved `drupal_stale_file_threshold` values to state.
Comment #3
Cameron Tod CreditAttribution: Cameron Tod commentedWoops, had a bad name on the update hook.
Comment #4
BerdirShould use the new helper function for the upgrade now.
Comment #5
Cameron Tod CreditAttribution: Cameron Tod commentedNew patch with variable as config instead of state.
Comment #6
Cameron Tod CreditAttribution: Cameron Tod commentedDuh, wrong config key.
Comment #7
BerdirRTBC if it passes the tests.
Comment #8
catchCommitted/pushed to 8.x, thanks!