Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#12 | user_password_reset_timeout-1814558-12.patch | 3.24 KB | LinL |
#9 | user_password_reset_timeout-1814558-9.patch | 3.24 KB | LinL |
#4 | user_password_reset_timeout-1814558-4.patch | 3.24 KB | LinL |
#3 | user_password_reset_timeout-1814558-3.patch | 3.11 KB | LinL |
#1 | user_password_reset_timeout-1814558-1.patch | 3.12 KB | LinL |
Comments
Comment #1
LinL CreditAttribution: LinL commentedFirst stab at converting to config - here's a patch.
Comment #3
LinL CreditAttribution: LinL commentedComment #4
LinL CreditAttribution: LinL commentedIncluded in user.settings.yml instead of a separate yml.
Comment #5
BerdirDo we want to extend the existing generic user.settings update function to include this instead of adding another one?
8.x -> 8.x updates aren't supported and this is just an internal setting without UI that nobody has set to something else (in 8.x at least ;)) anyway.
Would avoid adding another one that could possibly conflict with other issues.
Comment #6
gddI don't know, update settings conflicts are par for the course, and I can't remember a time when we've added stuff into existing update functions like that before? I'd rather just get this in and move on. I looked it over and otherwise it looks good, so lets go!
Comment #7
Berdir@heyrocker #1807266: Convert user_cancel_method variable to CMI system does exactly that, that's why I suggested it.
Anyway, getting this in like this is fine with me as well.
Comment #8
webchickActually, I agree it'd be nice to group like-updates together in the same update function. Can we get a quick re-roll for that? Feel free to mark back to RTBC after; as long as testbot says it's good, I can commit it.
Comment #9
LinL CreditAttribution: LinL commentedRe-rolled to remove extra update function.
Comment #10
BerdirThanks, back to RTBC then, as webchick requested.
Comment #11
webchickLooks like this needs a quick re-roll.
Comment #12
LinL CreditAttribution: LinL commentedComment #13
BerdirAnd back to RTBC again.
Comment #15
LinL CreditAttribution: LinL commented#12: user_password_reset_timeout-1814558-12.patch queued for re-testing.
Comment #16
LinL CreditAttribution: LinL commentedBack to RTBC.
Comment #17
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.