Support from Acquia helps fund testing for Drupal Acquia logo

Comments

LinL’s picture

Status: Active » Needs review
FileSize
3.12 KB

First stab at converting to config - here's a patch.

Status: Needs review » Needs work

The last submitted patch, user_password_reset_timeout-1814558-1.patch, failed testing.

LinL’s picture

Status: Needs work » Needs review
FileSize
3.11 KB
LinL’s picture

Included in user.settings.yml instead of a separate yml.

Berdir’s picture

Do we want to extend the existing generic user.settings update function to include this instead of adding another one?

8.x -> 8.x updates aren't supported and this is just an internal setting without UI that nobody has set to something else (in 8.x at least ;)) anyway.

Would avoid adding another one that could possibly conflict with other issues.

gdd’s picture

Status: Needs review » Reviewed & tested by the community

I don't know, update settings conflicts are par for the course, and I can't remember a time when we've added stuff into existing update functions like that before? I'd rather just get this in and move on. I looked it over and otherwise it looks good, so lets go!

Berdir’s picture

@heyrocker #1807266: Convert user_cancel_method variable to CMI system does exactly that, that's why I suggested it.

Anyway, getting this in like this is fine with me as well.

webchick’s picture

Status: Reviewed & tested by the community » Needs work

Actually, I agree it'd be nice to group like-updates together in the same update function. Can we get a quick re-roll for that? Feel free to mark back to RTBC after; as long as testbot says it's good, I can commit it.

LinL’s picture

Assigned: LinL » Unassigned
Status: Needs work » Needs review
FileSize
3.24 KB

Re-rolled to remove extra update function.

Berdir’s picture

Status: Needs review » Reviewed & tested by the community

Thanks, back to RTBC then, as webchick requested.

webchick’s picture

Status: Reviewed & tested by the community » Needs work

Looks like this needs a quick re-roll.

LinL’s picture

Status: Needs work » Needs review
FileSize
3.24 KB
Berdir’s picture

Status: Needs review » Reviewed & tested by the community

And back to RTBC again.

Status: Reviewed & tested by the community » Needs work
Issue tags: -Configuration system

The last submitted patch, user_password_reset_timeout-1814558-12.patch, failed testing.

LinL’s picture

Status: Needs work » Needs review
Issue tags: +Configuration system
LinL’s picture

Status: Needs review » Reviewed & tested by the community

Back to RTBC.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.