Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
hey
this is another feature that didn't made it to D7 core.
can you port it please?
Comment | File | Size | Author |
---|---|---|---|
#28 | d7port-908434-28.patch | 18.82 KB | MiSc |
#27 | 908434.27-d7-port.patch | 28.65 KB | deviantintegral |
#26 | 908434.26-d7-port.patch | 28.78 KB | deviantintegral |
#25 | 908434.25-d7-port.patch | 28.78 KB | deviantintegral |
#20 | port_to_d7-908434-20.patch | 18.51 KB | MiSc |
Comments
Comment #1
elliotttt CreditAttribution: elliotttt commentedI'd like to volunteer to do this with the previously mentioned adjustments/bug fixes as a new 7.x/2.x branch
Comment #2
likewhoa CreditAttribution: likewhoa commentedsubscribing
Comment #3
danharper CreditAttribution: danharper commentedSubscribing.
Looking to migrate to Drupal 7 and I require this module
Thanks.
Comment #4
epoitras CreditAttribution: epoitras commentedsubscribing
Comment #5
mgiffordHas anyone tried doing a rough upgrade via http://drupal.org/project/coder
Would be useful to get the ball rolling on this module in any case.
Comment #6
Docc CreditAttribution: Docc commentedA start. Didn't test the user autocomplete yet as i only needed roles.
Only support for "taxonomy_term_reference" field type atm.
Comment #7
rwt CreditAttribution: rwt commentedAny updates on the port? Module from Docc does not work with D7.8
Comment #8
witchcraft CreditAttribution: witchcraft commentedupdated port working on d7.10 using coder
Comment #9
mgiffordIt's great that both @Docc & @witchcraft have uploaded new modules as .zip files.
It's almost always easier to review changes if people use the latest version from the repository:
http://drupal.org/node/360339/git-instructions
and then build a patch based on that so it is easy to see what exactly has changed.
Terrific that it has been run through Coder!
Comment #10
witchcraft CreditAttribution: witchcraft commentedi am a bit new to git , i have the generated patch by coder .
everyone wellcome to review changes
Comment #11
MiSc CreditAttribution: MiSc commentedGreat, I am really interested in get this into D7, I will look into the patch and see if everything works as it should.
Comment #12
MiSc CreditAttribution: MiSc commentedTook a look on this, and now I almost have it working on D7 (applied the patch, but had some problems with choosing users on the permission page, fixed that).
Hopefully I will get some time later this week. Attached patch (this replaces patch in comment #10). Maybe we could collaborate on this witchcraft?
Comment #13
MiSc CreditAttribution: MiSc commentedUpdated to need review (and version is for drupal 7.x - but that is not selectable due that the fact that the version does not exist yet :-)
Comment #14
MiSc CreditAttribution: MiSc commentedI think that the only things that works now in the d7 patch is adding permissions on the term page
Comment #15
MiSc CreditAttribution: MiSc commentedA little update, but still a lot of work to do. Used some of Docc's code from comment #6 also.
Comment #16
MiSc CreditAttribution: MiSc commentedOkay, could not let this go, so I did some more work on it, seems like it is almost fully functioning, it throws an error when you try to delete a term, maybe someone else could look on that?
Comment #17
witchcraft CreditAttribution: witchcraft commentedi will be glad to help but i do not know any of code stuff :)
i barely know how to use coder module.
if you need some test to patch i can do so...
something else
i have also made a port with coder to this module Vocabulary Permissions Per Role there is a diffrence between the two,
but it will be the complete permissions to vocabulary and terms
good job b.t.w.
Comment #18
witchcraft CreditAttribution: witchcraft commented@MiSc I Have tested the patch in comment #16 ,
Clean drupal install ,User with role "editor" and permission to edit terms.
UID1 cannot delete term whan module enable .
i cannot see any error.
hope it was helpful .
Comment #19
MiSc CreditAttribution: MiSc commentedDid some clean up and changed a word in the README because of different structure in d7. Still breaks when you try to delete a term. @witchcraft, thanks for testing it out.
Should be interesting to also get Vocabulary Permissions Per Role in d7, but first a fully functional Taxonomy Term Permissions :-).
Comment #20
MiSc CreditAttribution: MiSc commentedAnd the patch...
Comment #21
witchcraft CreditAttribution: witchcraft commentedcan you guide me a bit ?
what is the git command for revert a patch .
i want to test the new patch and see the progress...
so how to unpatch the patch that i used in comment 16?
Comment #22
MiSc CreditAttribution: MiSc commentedYou could reverse a patch with
git apply -R filename.patch
orgit reset --hard
(if you have not committed your changes)Comment #23
witchcraft CreditAttribution: witchcraft commentedThanks for git command that works like a charm .
i tested patch #20 .
here is the result
whan the "editor" user try to delete the term i got error from apache2 log and a white screen :
line 74 is :
I'am trying my best to understand this but i canot figure that out .
its about the selection of permissions ?
Its an Honor to collaborate with you.
Thanks for you Patience with me, you very kind !
Comment #24
deviantintegral CreditAttribution: deviantintegral commentedI did a quick read through the patch in #20 and it looks pretty reasonable. Let's get this PHP error sorted out and we can commit this to a new branch and open up new issues for any specific bugs or changes.
Comment #25
deviantintegral CreditAttribution: deviantintegral commentedHere's a patch that fixes the error when deleting terms. I generated this with git format-patch, so if anyone wants to apply it use git am.
Some light testing and this looks OK. Two things I noticed:
These can probably be addressed in followup issues.
The commits are:
Comment #26
deviantintegral CreditAttribution: deviantintegral commentedUse this one instead, the one in #25 has a stray error_log() call in it.
Comment #27
deviantintegral CreditAttribution: deviantintegral commentedObviously must be Friday.
Comment #28
MiSc CreditAttribution: MiSc commentedThis is fun :-).
Removed weight, I could not decide where the permissions settings should be at all... What do you think?
Also fixed the deletion in the database.
Comment #29
mgiffordIsn't this fixed? I'll assume so since @MiSc is a maintainer and there's a D7 dev & beta release.