Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
During the fast development of views to d8 some parts of the UI didn't got converted, because there hasn't been tests for that small feature and you shouldn't drop backward compability layers without it.
Proposed resolution
This issue fixes the linking to other displays UI and adding tests for it.
Original report by [username]
// Text of original report here.
(for legacy issues whose initial post was not the issue summary)
C:\xampp\htdocs\views\lib\Drupal\views\Plugin\views\display\DisplayPluginBase.php
1227 $link_display = empty($this->view->display[$display_id]) ? t('None') : check_plain($this->view->display[$display_id]['display_title']);
2 matches in C:\xampp\htdocs\views\lib\Drupal\views\Plugin\views\display\DisplayPluginBase.php
Comment | File | Size | Author |
---|---|---|---|
#20 | drupal-1810816-20.patch | 4.22 KB | damiankloip |
#17 | drupal-1810816-17.patch | 4.23 KB | dawehner |
#15 | durpal-1810816-15.patch | 4.07 KB | dawehner |
#12 | 1810816-12.patch | 4.78 KB | damiankloip |
#8 | 1810816-8.patch | 4.75 KB | damiankloip |
Comments
Comment #1
dawehnerPatches!
Comment #2
dawehnerHere are tests + the fix
Comment #4
damiankloip CreditAttribution: damiankloip commentedThis should fix the tests.
Comment #5
xjmComment #6
fastangel CreditAttribution: fastangel commentedI attached one patch with the reroll.
Comment #7
tim.plunkettThis is still wrong, assertTrue on $this->xpath is ALWAYS true. It's asserting a constant, not a string, and should use replacement. Something like
Needs a real comment.
Comment #8
damiankloip CreditAttribution: damiankloip commentedI think we should also assert the xpath against the actual link we deleted the display for and not just that we have that class.
Added the comment too.
Comment #9
dawehnerWe maybe should open an follow up on that, #1826358: Redirect the user to the active editing display after saving.
Comment #10
xjm#8: 1810816-8.patch queued for re-testing.
Comment #11
webchickThis needs a re-roll.
Comment #12
damiankloip CreditAttribution: damiankloip commentedRerolled, thanks again Tim! (That damn views UI patch) ;)
Comment #14
dawehner#1829822: Write a test which tests the UI for all of the handlers will fix these test errors.
Comment #15
dawehnerJust a rerole.
Comment #17
dawehnerMuch better this time.
The good parts of views, if something fails then it fails everywhere :)
Comment #18
xjmThis could use something resembling a summary. :)
Comment #19
dawehnerUpdated.
Comment #20
damiankloip CreditAttribution: damiankloip commentedRerolled.
Comment #21
dawehnerThis has been RTBC before, thanks for the rerole!
Comment #22
catchCommitted/pushed to 8.x, thanks!
Comment #23.0
(not verified) CreditAttribution: commentedUpdated