Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
See #1420534: Consider a new hook - hook_ctools_automodal_paths() rather than using hook_menu() #4.
These patches (especially #1420534: Consider a new hook - hook_ctools_automodal_paths() rather than using hook_menu()) drastically change the way this module works. It seems like the best path forward would be to create a 2.x branch with these modifications so we can keep the development on d.o., rather than forking projects on github.
I created a fork with a fix for #1422002: How do I use with a node form? at https://github.com/jlyon/ctools_automodal that I believe has all the latest code.
Comments
Comment #1
acouch CreditAttribution: acouch commented+1 for this. Would be great to get that code created by wojtha on D.O.
Perhaps we could make him a maintainer of this module?
Comment #2
jlyon CreditAttribution: jlyon commentedI just updated my fork of wojth's github fork at https://github.com/jlyon/ctools_automodal.
Additional features:
Comment #3
wojtha CreditAttribution: wojtha commentedNice :-)
Comment #4
nicholas.alipaz CreditAttribution: nicholas.alipaz commentedIt may be best to follow the steps in http://drupal.org/node/251466 if you would like to become a maintainer.
Comment #5
jlyon CreditAttribution: jlyon commentedFiled a request at #1784188: Request to become co-maintainer/maintainer of ctools_automodal.
Comment #6
Dave ReidAs I stated in http://drupal.org/node/1420534#comment-6379370 I would not be opposed to moving to the new hook with backwards-compatibility in 7.x-1.x and not needing a new branch. Other than that I haven't really seen any big reason why we need a new branch?
Comment #7
acouch CreditAttribution: acouch commentedThe reason for the branch is that the updated module is three times as large in the .module file, contains an example module as well as an api.php file: https://github.com/jlyon/ctools_automodal
It would be extremely tedious to merge each feature of the updated module into this project. Creating a new branch would allow you to continue to maintain what is there as well as have a branch with the new features.
Alternatively we could copy the entire updated updated module into the 7.x-1.x branch. Would that be a better alternative Dave Reid?
Comment #8
jlyon CreditAttribution: jlyon commentedI agree with most of acouch's points that the api for the "2.x branch" is entirely different, which is what I thought initally that a new branch made the most sense. hook_modal_paths() and hook_modal_styles() don't even exist in 7.x-1.1.
@Dave Reid, I can understand your desire not to create too many branches, as well. If we want to go ahead with merging everything into the current branch, I will focus my efforts on that. It doesn't seem like it will be too difficult, although it seems like there might be some issues turning off the automatic AJAX form submission in modals the the "2.x branch" sets up by default.
Comment #9
wojtha CreditAttribution: wojtha commentedI also think that 2.x version would make more sense. It is a kind of different module now with extended API and much more powerful.
But in any case we need to support the 1.x way of modal window registration - legacy support or at least provide a update path for it.
Comment #10
capellicUpdate please?
Comment #11
wzoom CreditAttribution: wzoom commentedI think, this is very useful module. Please make the version 2.x official so we can test it and push it forward.
Comment #12
fox_01 CreditAttribution: fox_01 commentedThere are some great changes in 2.x.
Is there a new status about publishing it on drupal?
Comment #13
Renee S CreditAttribution: Renee S commentedI'd love a v.2 of this module. I also have some code for making it work with ECK if anybody is interested, just some minor tweaks in how the submit handler works. That's here: https://gist.github.com/reinette/2720f32125dbceed071b, note that I'm using ctools_automodal_admin to load all my paths, but, the general idea stands.
Comment #14
alansaviolobo CreditAttribution: alansaviolobo commentedwith the release of the 7,x-1,2 version of ctools_automodal_admin module on 28/dec/2019, the published version of this module doesnt work with the admin interface.
Requesting release of the v2 of this module.