Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Just converting variables.
Meta issue: #1775842: [meta] Convert all variables to state and/or config systems
Comment | File | Size | Author |
---|---|---|---|
#5 | menu_variable_state_with_upgrade_2.patch | 4.11 KB | aspilicious |
#3 | menu_variable_state_with_upgrade.patch | 4.14 KB | aspilicious |
menu_variable_state.patch | 3.55 KB | aspilicious | |
Comments
Comment #1
aspilicious CreditAttribution: aspilicious commentedComment #2
aspilicious CreditAttribution: aspilicious commentedNeeds update functions, working on that.
Comment #3
aspilicious CreditAttribution: aspilicious commentedDone
Comment #4
pfrenssenYou can save 3 lines here:
By doing this:
This hunk has a fatal error: too many parentheses:
And because D8 depends on PHP 5.3, you can shorten the above code to this:
Same for this:
Comment #5
aspilicious CreditAttribution: aspilicious commentedAnother try.
Comment #6
pfrenssenLooks good, thanks!
Comment #7
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.
Comment #9
ianthomas_ukThis didn't catch all menu_* variables. I have filled #2102521: Finish converting menu.module to CMI for the remainder.