Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#10 | 1798880-convert-teaser_length-to-CMI-3.patch | 1.24 KB | mtunay |
#9 | 1798880-9-convert-teaser_length-to-CMI.patch | 1.53 KB | LinL |
#3 | 1798880-convert-teaser_length-to-CMI.patch | 1017 bytes | andyceo |
Comments
Comment #1
LinL CreditAttribution: LinL commentedChanging title - it is configuration not state.
Comment #2
larowlanTagging
Comment #3
andyceo CreditAttribution: andyceo commentedI think it is good time to breake the backward compatibility with variable 'teaser_length', that goes from Drupal 6.
IMHO, more suitable name for this config is 'default_summary_length', because:
1. It is summary length
2. It is default, because this setting is given when Drupal has no any information about "text field with summary" summary length. This happens when user create a "text field with summary" and didn't setup its widget settings. So, if administrator want, he can update this 'default_summary_length' config, so any new and not-configured "text field with summary" fields will use it.
Comment #4
andyceo CreditAttribution: andyceo commentedSorry, forgot to change issue status for testbot.
Comment #5
andyceo CreditAttribution: andyceo commented#3: 1798880-convert-teaser_length-to-CMI.patch queued for re-testing.
Comment #6
aspilicious CreditAttribution: aspilicious commentedLooks good
Comment #7
catchThis is missing the upgrade path isn't it?
Comment #8
aspilicious CreditAttribution: aspilicious commentedYou're so right!
Comment #9
LinL CreditAttribution: LinL commentedRe-rolled and added update function.
Comment #10
mtunay CreditAttribution: mtunay commentedI added the update hook...
Comment #11
LinL CreditAttribution: LinL commentedFollowing on from the name change here:
teaser_length
todefault_summary_length
I'm wondering if a similar change should be made in aggregator?
EDIT: I've added this issue: #1830068: Change teaser_length to default_summary_length in aggregator?
Comment #12
LinL CreditAttribution: LinL commentedOops, cross-post :)
Comment #14
LinL CreditAttribution: LinL commented#9: 1798880-9-convert-teaser_length-to-CMI.patch queued for re-testing.
Comment #15
mtunay CreditAttribution: mtunay commented#10: 1798880-convert-teaser_length-to-CMI-3.patch queued for re-testing.
Comment #16
mtunay CreditAttribution: mtunay commentedsorry, have forgotten the config.yml file. LinL post works fine.. Thanks.
Comment #17
aspilicious CreditAttribution: aspilicious commentedmtunay, please don't retest your file. It is missing the .yml file. If the patch from LinL comes back green that one is rtbc.
Comment #19
LinL CreditAttribution: LinL commentedChanging status for patch in #9
Comment #20
aspilicious CreditAttribution: aspilicious commented#9! is rtbc :)
Comment #21
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.