Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Split "This maybe" into "This may be", hyphenated some adjectives, and standardized the naming of modules.
Comment | File | Size | Author |
---|---|---|---|
#8 | 1829366-settings-grammar-3.patch | 974 bytes | gcassie |
#5 | 1829366-settings-grammar-2.patch | 1.66 KB | gcassie |
#1 | 1829366-settings-grammar.patch | 3.61 KB | gcassie |
Comments
Comment #1
gcassie CreditAttribution: gcassie commentedpatch attached
Comment #3
Anonymous (not verified) CreditAttribution: Anonymous commentedI have objection to these two
+ * By default, Drupal configuration files are stored in a randomly-named
+ * of heavily-visited sites and may also provide other site caching,
The added hyphen is unnatural and unneeded.
Comment #4
jhodgdonRE #3 - actually I think those two changes are correct by English grammar/punctuation rules.
The changes in the patch look fine to me. But please take the chunk out that is not default.settings.php (we try to keep issues to one topic only). Thanks!
Comment #5
gcassie CreditAttribution: gcassie commentedSorry, the SessionTest stuff snuck in. New patch for default.settings.php only attached.
I double-checked the hyphens and since the words in question here are adverbs, they are not strictly needed. The new patch omits them.
Comment #6
jhodgdonThanks - this patch looks fine! I'll get it committed next week (there are a lot of sprints happening this weekend for BADCamp and committing patches ties up the test bot, so postponing a few days). This patch will most likely still apply to 7.x too; if not, after commit to 8.x someone can backport.
Comment #8
gcassie CreditAttribution: gcassie commentedLooks like the Ban logic was removed from default.settings.php .
Comment #9
jhodgdonThanks!
Comment #10
jhodgdonThanks! Sorry for the delay (there were sprints going on and I was avoiding commits for a while and then got busy) -- committed to 8.x and 7.x.
gcassie: is that your first core patch? Congrats!