There should be a test similar to HandlersAllTest which just CRUDs some handler to be it is working.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Status: Active » Needs review
FileSize
3.71 KB

That is just a start, but sadly the tests aren't working yet.

Status: Needs review » Needs work

The last submitted patch, drupal-1829822-1.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
2.32 KB
4.3 KB
2.45 KB

Fixed the tests.

There are no valid relationship handlers for views_test_data yet.

tim.plunkett’s picture

+++ b/core/modules/views/lib/Drupal/views/Tests/UI/HandlerTest.phpundefined
@@ -0,0 +1,62 @@
+      elseif ($type != 'relationship') {

Should have been ==

tim.plunkett’s picture

Priority: Normal » Major

This is test coverage we should have had already, it is central to the functionality of Views, and it blocks a couple other issues.

damiankloip’s picture

+++ b/core/modules/views/lib/Drupal/views/Tests/UI/HandlerTest.phpundefined
@@ -0,0 +1,62 @@
+      // Different handler types need to use different handlers.

Should this be Area handler types ...?

Other than that, looks good to go, and we need this one quite desperately.

damiankloip’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
4.3 KB

Rerolled with the minor doc change. I think it's good to go.

dawehner’s picture

I totally agree, and we need this for other people which port the views parts of their changes.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.