Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mtunay’s picture

First patch.. Hope it's ok..

mtunay’s picture

Status: Active » Needs review

Test it please..:)

Berdir’s picture

Status: Needs review » Needs work

the translation_ prefix can be removed, that is no longer necessary. Looks good otherwise.

mtunay’s picture

Status: Needs work » Needs review
FileSize
2.91 KB

Done...

Berdir’s picture

+++ b/core/modules/translation/config/translation.settings.ymlundefined
@@ -0,0 +1 @@
+language_type: "language_interface"
\ No newline at end of file

+++ b/core/modules/translation/translation.installundefined
@@ -15,3 +15,16 @@ function translation_update_8000() {
+}
\ No newline at end of file

Make sure to add an empty line at the end of these two files so that git stops complaining about it.

+++ b/core/modules/translation/translation.installundefined
@@ -15,3 +15,16 @@ function translation_update_8000() {
     ->execute();
 }
+
+
+/**
+* Moves "translation_language_type" from variable to config.

While you're at it, there is one empty line too much here, that's not necessary.

mtunay’s picture

Berdir’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Configuration system

Looks good, RTBC if the tests pass.

mtunay’s picture

Status: Reviewed & tested by the community » Needs review

Like..

penyaskito’s picture

Status: Needs review » Reviewed & tested by the community

RTBCing.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.