Created from #1775842: [meta] Convert all variables to state and/or config systems.

theme_settings
theme_$theme_settings

CommentFileSizeAuthor
#8 theme_system_variables_to_config-1830978-8.patch2.19 KB8thom
#4 theme_system_variables_to_config-1830978-4.patch2.01 KB8thom
#2 theme_system_variables_to_config-1830978-2.patch5.1 KB8thom
#1 theme_system_variables_to_config-1830978-1.patch5.09 KB8thom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

8thom’s picture

8thom CreditAttribution: 8thom commented
Status: Active » Needs review
FileSize
theme_system_variables_to_config-1830978-1.patch5.09 KB

First attempt...

8thom’s picture

8thom CreditAttribution: 8thom commented
FileSize
theme_system_variables_to_config-1830978-2.patch5.1 KB

Sorry didn't realise there was other issues that refer to these variables which are putting config into system.site,
updated patch to reflect this.

8thom’s picture

8thom CreditAttribution: 8thom commented
Status: Needs review » Needs work

Will break up this patch and include in #1798872: Convert admin_theme to CMI & #1829224: Convert the 'theme_default' variable to CMI

8thom’s picture

8thom CreditAttribution: 8thom commented
Issue summary: View changes

included link to issue #1775842

8thom’s picture

8thom CreditAttribution: 8thom commented
Status: Needs work » Needs review
FileSize
theme_system_variables_to_config-1830978-4.patch2.01 KB

Here it is, not too sure how to make update function for theme_$theme_settings, are there any examples of updating dynamic variables?

8thom’s picture

8thom CreditAttribution: 8thom commented

#2: theme_system_variables_to_config-1830978-2.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, theme_system_variables_to_config-1830978-4.patch, failed testing.

8thom’s picture

8thom CreditAttribution: 8thom commented
Status: Needs work » Needs review

#4: theme_system_variables_to_config-1830978-4.patch queued for re-testing.

8thom’s picture

8thom CreditAttribution: 8thom commented
FileSize
theme_system_variables_to_config-1830978-8.patch2.19 KB

This patch Include update function for theme_$theme_settings.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

This is quite a complicated issue and the conversion has already been attempted in #1712250: Convert theme settings to configuration system. I'm tempted to mark this issue as a duplicate. The essential issue here is that theme settings should come from a configuration file and not be built from multiple configurations at runtime - at the moment theme settings are built from defaults in code, global settings in variable (which this patch converts), theme .info files and a theme specific variable.

Additionally the system.theme namespace is now used for enabled themes so we need to be careful about using it for this.

8thom’s picture

8thom CreditAttribution: 8thom commented

#8: theme_system_variables_to_config-1830978-8.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, theme_system_variables_to_config-1830978-8.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Component: configuration system » theme system
Issue tags: +Configuration system
aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Closed (duplicate)

Already fixed in the linked issue above

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Issue summary: View changes

converted issue to cover theme_settings & theme_$theme_settings