Update notification is printed more than one time [#1817680]

The message advising that a Drupal update is available sometimes is shown 2 or 3 times:

There is a security update available for your version of Drupal. To ensure the security of your server, you should update immediately! See the available updates page for more information and to install your missing updates.

There is a security update available for your version of Drupal. To ensure the security of your server, you should update immediately! See the available updates page for more information and to install your missing updates.

Comment	File	Size	Author
#4	double-notification-pre-patch.png	31.5 KB	haydeniv
#4	single-notification-after-patch.png	27.2 KB	haydeniv
#4	update_module-duplicate_notifications-1817680-4.patch	1.14 KB	haydeniv
#4
	screenshot update notification issue.png	19.25 KB	Pere Orga

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #2

jonhattan

Spanish

Plasencia

CreditAttribution: jonhattan commented 4 November 2012 at 10:07

Status:

Active

» Closed (duplicate)

Already fixed. See #1428032: Default drupal_set_message $repeat to FALSE instead of TRUE (followup)

This is the change record: http://drupal.org/node/1827234

Comment #3

Anonymous (not verified) CreditAttribution: Anonymous commented 5 November 2012 at 13:06

Version:	8.x-dev	» 7.x-dev
Status:	Closed (duplicate)	» Active

So I see from #1428032-19: Default drupal_set_message $repeat to FALSE instead of TRUE (followup) that it isn't committed to D7. The admin messages need to declare the $repeat parameter as FALSE for D7.

Comment #4

haydeniv CreditAttribution: haydeniv commented 11 November 2012 at 08:23

Status:

Active

» Needs review

File	Size
update_module-duplicate_notifications-1817680-4.patch	1.14 KB

single-notification-after-patch.png	27.2 KB
double-notification-pre-patch.png	31.5 KB

This has bothered me for a while now. Simple fix. Sorry don't know how to write a test for this or if it needs one.

Here are some manual steps to test:

Clean install Drupal
Install a module that has a security update available (I chose entity 7.x-1.0-beta11)
Edit the Article content type Tags field
Try to set a default value a couple times and save the settings, you should have multiple security update notices

I have uploaded a couple screenshots to demonstrate the patch.

Comment #5

Anonymous (not verified) CreditAttribution: Anonymous commented 12 November 2012 at 13:42

Status:

Needs review

» Reviewed & tested by the community

Looks good to me. As for a test you would need to get the values of the message array and test that there was only one entry for the notification. I don't think it is worth a test at this point, but if there is it would need to be a new issue for D8.