Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The following adds field support for the new Diff 7.x-3.x branch.
Comment | File | Size | Author |
---|---|---|---|
#10 | diff-er.jpg | 46.03 KB | amitaibu |
entityreference-diff-7.x-3.x-support.patch | 2.76 KB | Alan D. | |
Comments
Comment #1
mitchell CreditAttribution: mitchell commentedI tested this patch, and everything works well. Thanks, Alan D.
Comment #2
mitchell CreditAttribution: mitchell commentedTagging.
Comment #3
twardnw CreditAttribution: twardnw commentedThis checks out for me. Changed a entity reference field and it is marking nicely in diff.
Comment #4
adamdicarlo CreditAttribution: adamdicarlo commentedTagging and elevating to critical because the drupal.org upgrade depends on this, and the functionally complete deadline is the end of this month.
Comment #5
adamdicarlo CreditAttribution: adamdicarlo commentedI tested this on a local sandbox site and it works great. +1 RTBC.
Comment #6
amitaibuShouldn't we show a link to the entity, instead of just the title?
Comment #7
Alan D. CreditAttribution: Alan D. commentedThe link may be rendered as escaped HTML and would look untidy. Terms, files, etc, all just have titles and optional additional extras like the entity ID.
Comment #8
amitaibu> The link may be rendered as escaped HTML and would look untidy
I mean you can use entity_label() and entity_uri(), no?
Comment #9
Alan D. CreditAttribution: Alan D. commentedSorry, I'm not following. This already uses entity_label().
If you supply a link to the Diff engine, it is escaped to this
i.e. Rendered like this
<a href="path/to/entity">entity label</a>
Comment #10
amitaibuHere's what I mean:
Comment #11
adamdicarlo CreditAttribution: adamdicarlo commentedNope - the DiffEngine actually escapes that output. We *can't* make it a clickable link. It would read as HTML code, like Alan said in #9.
Comment #12
mitchell CreditAttribution: mitchell commentedThere's an issue to encode html entities: #458672: Use real HTML-Diff algorithm in Drupal Diff module.
Comment #13
amitaibuCommitted.
I think it would be nice to have a link, once Diff supports it.
Comment #14
hass CreditAttribution: hass commentedWill there be a RC6 or final soon? :-)