Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
It's a new theme for drupal 7.
http://drupal.org/sandbox/sibiraj/1825208
Comment | File | Size | Author |
---|---|---|---|
#11 | bug.png | 52.67 KB | zymphonies-dev |
#8 | Screenshot_1.png | 22.92 KB | Sibiraj PR |
#4 | Welcome to Drupal review - Drupal review.png | 60.47 KB | zymphonies-dev |
Comments
Comment #1
zymphonies-dev CreditAttribution: zymphonies-dev commentedComment #2
zymphonies-dev CreditAttribution: zymphonies-dev commentedHI,
Please add sandbox url and git repository
thanks
shanid kv
Comment #3
Sibiraj PR CreditAttribution: Sibiraj PR commentedhi,
I added the sandbox url at the bottom of the image. Please check.
Comment #4
zymphonies-dev CreditAttribution: zymphonies-dev commentedHI,
Manual review:
1) style is effecting on admin part also
2) menu not displaying
i have created 3 pages but menus are not displaying
( explain in Summary if any module is required )
3) .container style is effecting on footer
you can write specific style or use different class name
( screenshot attached )
Thanks
Shanid kv
Comment #5
zymphonies-dev CreditAttribution: zymphonies-dev commentedComment #6
Sibiraj PR CreditAttribution: Sibiraj PR commentedHi shanidkv,
Thank you for your feedback. I changed the things you are mentioned in your previous comment. Please check.
Comment #7
idflood CreditAttribution: idflood commentedHi,
Nice theme. Here is a quick review (I just looked at the code, no real test here).
edit: Have a look at the coding standards: http://drupal.org/coding-standards
edit2: Here is an automated review: http://ventral.org/pareview/httpgitdrupalorgsandboxsibiraj1825208git
edit3: Changed link for better procedure to remove the master branch
Comment #8
Sibiraj PR CreditAttribution: Sibiraj PR commentedHi idflood,
Thank you for your feedback.
Followed all your point also made the changes.
I tested this code using coder module.
Comment #9
idflood CreditAttribution: idflood commentedGood work sibiraj. Though there are still some coding standard issues http://ventral.org/pareview/httpgitdrupalorgsandboxsibiraj1825208git
edit: The master branch is still accessible. The following should be enough to get rid of it:
Comment #10
Sibiraj PR CreditAttribution: Sibiraj PR commentedhi idflood,
Done the thing you have mentioned in this message. Now 7.x-1.x branch enabled
Comment #11
zymphonies-dev CreditAttribution: zymphonies-dev commentedHI,
Manual review:
1) Error in page--front.tpl.php
2) Please fix footer styling issue (screenshot attached)
thanks
shanidkv
Comment #12
klausiClosing due to lack of activity. Feel free to reopen if you are still working on this application.
If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)
Comment #12.0
klausiAdded the sandbox url