Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Some minor code cleanup needed to pass coder
Also fixed tests to use token, we needs extended coverage:
1) block
2) API functions
3) admin UI
Comment | File | Size | Author |
---|---|---|---|
#6 | 1835954-masquerade-6.patch | 15.7 KB | andypost |
#5 | 1835954-masquerade-5.patch | 16.19 KB | andypost |
#5 | 1835954-interdiff-5.txt | 9.49 KB | andypost |
#4 | 1835954-masquerade-4.patch | 13.69 KB | andypost |
#4 | 1835954-masquerade-4-1.patch | 13.53 KB | andypost |
Comments
Comment #1
andypostInitial patch, fixed code-style and started tests (still not passes switch 404)
Comment #2
andypostA bit extended test. I can't find a proper way to build a token
Comment #3
sunSome good clean-ups here. Though do you think we could move forward with #1836516: Port Masquerade to D8 and rewrite + simplify it into a new 2.x series first?
?
Yep, also noticed those. Seem to date back to D5.
Comment #4
andypost@sun thanx for review, this is a dubuggin staff - I'm trying to debug the session that should be fixed in #1555862: DrupalWebTestCase::drupalGetToken() does not add hash salt
patch includes additional cleanups from #1836516: Port Masquerade to D8 and rewrite + simplify it into a new 2.x series
Comment #5
andypostThe final patch I'm going to commit to D7
Comment #6
andypostAnother rount to pass tests