This theme delivers all the power of amazing Twitter Bootstrap web framework directly to your Drupal site. It is lightweight, responsive and ready to use out of the box. And perfect for subtheming as well.
Features
- Responsive design
- Amazing navbar with integrated logo, search box and main menu
- Elastic search box
- Main menu with dropdowns, unlimited nesting, headers and delimiters
- Affixed second sidebar region for table of contents, social plugins or something else
- Adjusted styles of pager and polls
- Perfect subtheming support
Screenshots
Similar themes
Info
- Live demo: http://tonystar.ru
- Project page: http://drupal.org/sandbox/tonystar/1825342
- Home page: http://tonystar.ru/projects/tweme
- Direct download link: http://drupal.org/files/tweme-7.x-1.x-dev.zip
- Git clone:
git clone --recursive --branch 7.x-1.x tonystar@git.drupal.org:sandbox/tonystar/1825342.git tweme
Reviews of other projects
- http://drupal.org/node/1191490#comment-6693038
- http://drupal.org/node/1637566#comment-6693078
- http://drupal.org/node/1715026#comment-6693132
- http://drupal.org/node/1835504#comment-6717564
- http://drupal.org/node/1827294#comment-6717608
- http://drupal.org/node/1837170#comment-6717646
- http://drupal.org/node/1832562#comment-6717718
- http://drupal.org/node/1814020#comment-6717758
- http://drupal.org/node/1711898#comment-6717774
Comment | File | Size | Author |
---|---|---|---|
#24 | strict warning tweme.png | 27.03 KB | Pere Orga |
#25 | tweme in opera mobile.png | 80.78 KB | Pere Orga |
#25 | tweme in firefox.png | 55.36 KB | Pere Orga |
#16 | tweme-coder.png | 2.73 KB | anydigital |
#15 | coder-result.txt | 1.85 KB | klausi |
Comments
Comment #0.0
anydigital CreditAttribution: anydigital commentedScreenshot added.
Comment #0.1
anydigital CreditAttribution: anydigital commentedAdded download link.
Comment #1
Pere OrgaLooks cool!
You should create another branch called 7.x-1.x and set it to default. See http://drupal.org/node/1127732
Also check some warnings (code style, etc) at http://ventral.org/pareview/httpgitdrupalorgsandboxtonystar1825342git
And wait for a real review :)
Comment #2
anydigital CreditAttribution: anydigital commentedThank you, netol!
Created 7.x-1.x branch. Still needs review of main functionality.
Comment #3
zymphonies-dev CreditAttribution: zymphonies-dev commentedHI,
Nice theme :)
Manual review:
1) RHS search bar is breaking
2) Drop down is not working
3) Give 5px space after button
( eg: go to blog page you can see two button save & cancel there is no space between two button. give 5px space between two buttons)
screenshot attached
please fix these issues
Thanks
http://www.zymphonies.com
Comment #4
anydigital CreditAttribution: anydigital commentedThank you shanidkv, I will fix that.
Comment #5
anydigital CreditAttribution: anydigital commentedThank you shanidkv for your review!
I fixed and improved my theme according to your comments:
1) Added special search form box to the navbar instead search form block. You can see it after enabling Search module.
2) Dropdown is working now! With unlimited unlimited nesting, headers and delimiters ;)
3) Added 5px space beetween control buttons.
Comment #6
anydigital CreditAttribution: anydigital commentedImproved navbar, separated ScrollSpy and merged sidebars.
You can download it by the link below:
Comment #6.0
anydigital CreditAttribution: anydigital commentedUpdated download link.
Comment #6.1
anydigital CreditAttribution: anydigital commentedUpdated features and screenshot
Comment #7
anydigital CreditAttribution: anydigital commentedAdding "PAReview: review bonus" tag.
Comment #8
herom CreditAttribution: herom commentedafter fixing the issues, you should probably repeat the automatic review yourself, until no issues remain there.
It is also not clear from the "jQuery 1.8.x" that it also refers to a drupal module (JQuery Update) that should be installed too.
The links for your requirements have been also mistakenly substituted.
The rest of the theme looks fine to me. Keep up the good work!
Comment #8.0
herom CreditAttribution: herom commentedAdded Reviews of other projects section.
Comment #9
anydigital CreditAttribution: anydigital commentedThank you herom for comments, I will work on it.
Also removed PAReview: review bonus tag until all issues are fixed.
Comment #10
anydigital CreditAttribution: anydigital commentedHello herom,
1) I fixed all issues reported by the automatic project reviewer at http://ventral.org/pareview/httpgitdrupalorgsandboxtonystar1825342git-7x-1x
2) Unfortunately there is no way to add "dependencies[] = ..." to theme
3) I replaced "Put" with "Unpack" and then "Put"
4) I also added sliding effect on losing focus to search box.
Comment #11
anydigital CreditAttribution: anydigital commentedIntegrated with Libraries API, refactored navbar search and menu building.
* Integrated with Libraries API.
* Used native theme_menu_tree() and theme_menu_link() instead of custom functions for building navbar menu.
* Refactored navbar search form building to use Form API.
* Separated js for affixing second sidebar.
* Added sliding effect on losing focus on search box.
* Added right margin to the search box.
* Refactored code.
* Fixed issues obtained by Drupal Code Sniffer.
* Refactored `include_once` statement.
* Updated README.txt.
Comment #12
anydigital CreditAttribution: anydigital commentedI totally refactored Tweme and made 3 manual reviews of other projects:
Please review my theme.
Comment #12.0
anydigital CreditAttribution: anydigital commentedRemoved Reviews of other projects until new version will be commited
Comment #13
Pere OrgaAFAIK jQuery Update module cannot be configured to use jQuery 1.8.x
Comment #14
anydigital CreditAttribution: anydigital commentedActually it can be. See http://drupal.org/project/jquery_update for more details:
Comment #15
klausiThere is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.
But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.
Comment #16
anydigital CreditAttribution: anydigital commentedThank you klausi for these great news!
And looking forward for the full project access.
I set the 7.x-1.x as default branch and removed the master branch.
Touching the Coder Sniffer results - I've already used the ":" alternative syntax instead of curly braces in template files. And for me Coder module don't notifies me about any warnings:
May be it was caused by missed semicolons after endif clauses?
Comment #17
klausiOoops, missed a security vulnerability.
tweme_menu_link__main_menu(): this is vulnerable to XSS exploits. If I have a main menu item with a title
<script>alert('XSSmenu');</script>
I get a nasty javascript popup on that page. You need to sanitize user provided input before printing if it has not been sanitized before. Please read http://drupal.org/node/28984 again.Comment #18
anydigital CreditAttribution: anydigital commentedRemoved XSS vulnerability.
I thought previously that menu link titles are always sanitized in preprocessors. I had to check their code.
Comment #18.0
anydigital CreditAttribution: anydigital commentedUpdated screenshots, added similar modules.
Comment #19
klausiPlease don't remove the security tag, we keep that for statistics and to show examples of security problems.
Comment #19.0
klausiAdded review.
Comment #20
anydigital CreditAttribution: anydigital commentedOk, got it.
Adding PAReview: review bonus tag.
My 3 new reviews of another projects:
Comment #21
klausiCool, back to RTBC.
Comment #22
anydigital CreditAttribution: anydigital commentedJust to speed up the process of full project application and to help you reviewing I made 3 extra reviews:
Thanks.
Comment #22.0
anydigital CreditAttribution: anydigital commentedAdded links to reviews.
Comment #23
Pere OrgaAs explained in #1819558: Explain that Drupal 7 version only supports 1.7.1 & 1.8.2 in dev snapshot, jQuery Update only updates jQuery to 1.8.2 in 7.x-2.x-dev, not in the current stable release 7.x-2.2. IMHO install instructions should be changed to reflect that.
Comment #24
Pere Orgadrupal_render(drupal_get_form('_tweme_navbar_search_form')
does a strict warning.Comment #25
Pere OrgaWhen the page is viewed as a mobile, the horizontal scroll bar appears, as there is some empty space on the right. It happens in desktop browsers, but also in mobile browsers.
Comment #26
Pere OrgaBtw, I'm using Bootstrap 2.2.1. The live demo (http://tonystar.ru) is ok, so maybe this could be my fault.
Another minor issue is that by default, this is using the non-minified javascript file. Ideally this should be explained in README, as the user may want to rename bootstrap.min.js to bootstrap.js
Comment #27
anydigital CreditAttribution: anydigital commentedThank you netol for your review.
> IMHO install instructions should be changed to reflect that.
I updated install instructions in README.txt, on the project page and on the home page: "Install the latest dev version of the jQuery Update module..."
> drupal_render(drupal_get_form('_tweme_navbar_search_form') does a strict warning.
Fixed this warning by separating the statement.
> When the page is viewed as a mobile, the horizontal scroll bar appears...
Can't reproduce that. Tested on desktop's Opera, FF, Chrome, IE, Safari and mobile's Safari and Chrome.
> Ideally this should be explained in README...
Added special note to the Configuration section in README.txt, on the project page and on the home page
Comment #28
Pere OrgaOk, let's see if I'm the only one that have that css issue.
Do yo plan to support multiple Bootstrap 2 versions? I think that 2.0 and 2.1 are quite different.
Comment #29
anydigital CreditAttribution: anydigital commented> Do yo plan to support multiple Bootstrap 2 versions? I think that 2.0 and 2.1 are quite different.
I've not planned to do that previously. But if many people will be interested - why not. Moreover 2.2 have just released.
Comment #30
Pere OrgaYes, Bootstrap 2.2.0 was released two weeks ago, but please don't claim that you support Bootstrap 2.x if it's not true.
Comment #31
klausiThanks for your contribution, tonystar!
I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #32
anydigital CreditAttribution: anydigital commentedThank you for all the reviews and the full project promotion! I really appreciate it!
Comment #33.0
(not verified) CreditAttribution: commentedAdded 3 more reviews.