Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave’s picture

Version: 7.x-3.x-dev » 6.x-2.x-dev
Status: Needs review » Patch (to be ported)

Committed.

longwave’s picture

Status: Patch (to be ported) » Needs review
FileSize
8.64 KB

I don't think this is going to prove what I expected it to prove.

Status: Needs review » Needs work

The last submitted patch, 1840260-uc_product_kit-tests-d6.patch, failed testing.

longwave’s picture

Status: Needs work » Needs review
FileSize
11.03 KB

This should fix the above failures and exceptions. There's a handful of seemingly harmless warnings, but it does appear that the default quantity field on new product kits has never worked in 6.x, and looking at 7.x it seems we do the wrong thing there as well; I guess nobody uses this feature enough to notice.

Status: Needs review » Needs work

The last submitted patch, 1840260-uc_product_kit-tests-d6-4.patch, failed testing.

longwave’s picture

Hmm. That doesn't happen when I run the tests locally.

longwave’s picture

Status: Needs work » Needs review
FileSize
11.06 KB

So assertFieldByName() works slightly differently on select elements in D6 and D7.

longwave’s picture

Status: Needs review » Active

Committed #7. Back to active, to add more tests for default quantity.

longwave’s picture

Version: 6.x-2.x-dev » 7.x-3.x-dev
Status: Active » Needs review
FileSize
1.36 KB
1.86 KB

Status: Needs review » Needs work

The last submitted patch, 1840260-kit-default-qty-tests-only.patch, failed testing.

longwave’s picture

Status: Needs work » Needs review
FileSize
2.77 KB
longwave’s picture

Version: 7.x-3.x-dev » 6.x-2.x-dev
FileSize
1.34 KB

Committed #11.

longwave’s picture

Status: Needs review » Fixed

Committed #12.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.