Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi,
Ì converted the query that gets all the combinations for the adjustments form to a dynamic query.
This way i can alter the query from a contrib module i just created on http://drupal.org/project/uc_attribute_ignore
This patch just does exactly the same as the original query, i just added a tag to it.
Could this be committed?
Cheers!
-- Tom
Comment | File | Size | Author |
---|---|---|---|
#4 | 1828596-attribute-adjustments-dynamic-query-4.patch | 1.86 KB | longwave |
#2 | 1828596-attribute-adjustments-dynamic-query.patch | 1.83 KB | longwave |
ubercart-attribute-query.patch | 1.83 KB | betz | |
Comments
Comment #1
betz CreditAttribution: betz commentedComment #2
longwaveI fixed the coding standard issues in the patch, but otherwise this is unchanged. We have a test for the adjustments form, so if this passes and you confirm it's okay, then I will commit it.
Comment #4
longwaveHeh, well at least the tests work.
Comment #5
betz CreditAttribution: betz commentedYes, I could't get this query to work in this way also.
So I guess it is more then just coding standards, it changes the query all together...
Comment #6
longwaveleftJoin() is not chainable, as it returns an alias. #4 seems to work, though.
Chainable vs non-chainable methods: http://drupal.org/node/1060924
Comment #7
longwaveComment #8
betz CreditAttribution: betz commentedJust applied patch to dev and tested, everything seems to work normally.
Comment #9
longwaveCommitted.